add check

Author: giancarloromeo

services/storage/src/simcore_service_storage/modules/celery/backends/_redis.py

@@ -3,6 +3,7 @@
 from typing import Final
 
 from models_library.progress_bar import ProgressReport
+from pydantic import ValidationError
 from servicelib.redis._client import RedisClientSDK
 
 from ..models import (
@@ -86,14 +87,25 @@ async def list_tasks(self, task_context: TaskContext) -> list[Task]:
 
         results = await pipe.execute()
 
-        return [
-            Task(
-                uuid=TaskUUID(key[search_key_len:]),
-                metadata=TaskMetadata.model_validate_json(metadata),
-            )
-            for key, metadata in zip(keys, results, strict=True)
-            if metadata is not None
-        ]
+        tasks = []
+        for key, raw_metadata in zip(keys, results, strict=True):
+            if raw_metadata is None:
+                continue
+
+            try:
+                task_metadata = TaskMetadata.model_validate_json(raw_metadata)
+                tasks.append(
+                    Task(
+                        uuid=TaskUUID(key[search_key_len:]),
+                        metadata=task_metadata,
+                    )
+                )
+            except ValidationError as exc:
+                _logger.debug(
+                    "Failed to deserialize task metadata for key %s: %s", key, str(exc)
+                )
+
+        return tasks
 
     async def remove_task(self, task_id: TaskID) -> None:
         await self._redis_client_sdk.redis.delete(_build_key(task_id))

services/storage/src/simcore_service_storage/modules/celery/models.py

@@ -4,7 +4,7 @@
 from uuid import UUID
 
 from models_library.progress_bar import ProgressReport
-from pydantic import BaseModel, model_validator
+from pydantic import BaseModel
 
 TaskContext: TypeAlias = dict[str, Any]
 TaskID: TypeAlias = str
@@ -45,13 +45,6 @@ class TaskMetadata(BaseModel):
     ephemeral: bool = True
     queue: TasksQueue = TasksQueue.DEFAULT
 
-    @model_validator(mode="before")
-    @classmethod
-    def _legacy_name_if_missing(cls, data: Any) -> Any:
-        if isinstance(data, dict) and "name" not in data:
-            data["name"] = ""
-        return data
-
 
 class Task(BaseModel):
     uuid: TaskUUID

services/web/server/src/simcore_service_webserver/tasks/_rest.py

@@ -85,7 +85,7 @@ async def get_async_jobs(request: web.Request) -> web.Response:
         [
             TaskGet(
                 task_id=f"{job.job_id}",
-                task_name=job.job_name or f"{job.job_id}",
+                task_name=job.job_name,
                 status_href=f"{request.url.with_path(str(request.app.router['get_async_job_status'].url_for(task_id=str(job.job_id))))}",
                 abort_href=f"{request.url.with_path(str(request.app.router['abort_async_job'].url_for(task_id=str(job.job_id))))}",
                 result_href=f"{request.url.with_path(str(request.app.router['get_async_job_result'].url_for(task_id=str(job.job_id))))}",