Skip to content

Commit 2fe521e

Browse files
author
Andrei Neagu
committed
rename
1 parent d45560d commit 2fe521e

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
from ...core.settings import ApplicationSettings
2525
from ...core.validation import (
2626
ComposeSpecValidation,
27+
get_and_validate_compose_spec,
2728
parse_compose_spec,
28-
validate_compose_spec,
2929
)
3030
from ...models.schemas.containers import ContainersComposeSpec
3131
from ...models.shared_store import SharedStore
@@ -76,10 +76,12 @@ async def store_compose_spec(
7676
_ = request
7777

7878
async with shared_store:
79-
compose_spec_validation: ComposeSpecValidation = await validate_compose_spec(
80-
settings=settings,
81-
compose_file_content=containers_compose_spec.docker_compose_yaml,
82-
mounted_volumes=mounted_volumes,
79+
compose_spec_validation: ComposeSpecValidation = (
80+
await get_and_validate_compose_spec(
81+
settings=settings,
82+
compose_file_content=containers_compose_spec.docker_compose_yaml,
83+
mounted_volumes=mounted_volumes,
84+
)
8385
)
8486
shared_store.compose_spec = compose_spec_validation.compose_spec
8587
shared_store.container_names = compose_spec_validation.current_container_names

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ class ComposeSpecValidation(NamedTuple):
185185
original_to_current_container_names: dict[str, str]
186186

187187

188-
async def validate_compose_spec( # pylint: disable=too-many-statements
188+
async def get_and_validate_compose_spec( # pylint: disable=too-many-statements
189189
settings: ApplicationSettings,
190190
compose_file_content: str,
191191
mounted_volumes: MountedVolumes,

services/dynamic-sidecar/tests/unit/test_core_validation.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
from servicelib.docker_constants import DEFAULT_USER_SERVICES_NETWORK_NAME
1313
from simcore_service_dynamic_sidecar.core.validation import (
1414
_connect_user_services,
15+
get_and_validate_compose_spec,
1516
parse_compose_spec,
16-
validate_compose_spec,
1717
)
1818
from simcore_service_dynamic_sidecar.modules.mounted_fs import MountedVolumes
1919

@@ -174,6 +174,6 @@ async def test_regression_validate_compose_spec(
174174
no_internet_spec: str,
175175
fake_mounted_volumes: MountedVolumes,
176176
):
177-
await validate_compose_spec(
177+
await get_and_validate_compose_spec(
178178
app.state.settings, no_internet_spec, fake_mounted_volumes
179179
)

0 commit comments

Comments
 (0)