testing formatting

Author: pcrespov

packages/models-library/src/models_library/api_schemas_webserver/users.py

@@ -1,7 +1,7 @@
 import re
 from datetime import date, datetime
 from enum import Enum
-from typing import Annotated, Any, Literal, Self
+from typing import Annotated, Any, Literal, Self, TypeAlias
 
 import annotated_types
 from common_library.basic_types import DEFAULT_FACTORY
@@ -20,6 +20,7 @@
     field_validator,
 )
 from pydantic.config import JsonDict
+from pydantic_extra_types.phone_numbers import PhoneNumberValidator
 
 from ..basic_types import IDStr
 from ..emails import LowerCaseEmailStr
@@ -212,10 +213,12 @@ def _validate_user_name(cls, value: str):
 #
 
 
+PhoneNumberStr: TypeAlias = Annotated[str, PhoneNumberValidator()]
+
+
 class MyPhoneRegister(InputSchema):
     phone: Annotated[
-        str,
-        StringConstraints(strip_whitespace=True, min_length=1),
+        PhoneNumberStr,
         Field(description="Phone number to register"),
     ]
 

packages/models-library/tests/test_users.py

@@ -1,8 +1,13 @@
-from models_library.api_schemas_webserver.users import MyProfileRestGet
+import pytest
+from models_library.api_schemas_webserver.users import (
+    MyPhoneRegister,
+    MyProfileRestGet,
+    PhoneNumberStr,
+)
 from models_library.api_schemas_webserver.users_preferences import Preference
 from models_library.groups import AccessRightsDict, Group, GroupsByTypeTuple
 from models_library.users import MyProfile
-from pydantic import TypeAdapter
+from pydantic import TypeAdapter, ValidationError
 
 
 def test_adapter_from_model_to_schema():
@@ -25,3 +30,24 @@ def test_adapter_from_model_to_schema():
     MyProfileRestGet.from_domain_model(
         my_profile, my_groups_by_type, my_product_group, my_preferences
     )
+
+
+@pytest.mark.parametrize(
+    "phone",
+    ["+41763456789", "+19104630364", "+1 301-304-4567"],
+)
+def test_valid_phone_numbers(phone: str):
+    # This test is used to tune options of PhoneNumberValidator
+    assert MyPhoneRegister.model_validate({"phone": phone}).phone == TypeAdapter(
+        PhoneNumberStr
+    ).validate_python(phone)
+
+
+@pytest.mark.parametrize(
+    "phone",
+    ["41763456789", "+09104630364", "+1 111-304-4567"],
+)
+def test_invalid_phone_numbers(phone: str):
+    # This test is used to tune options of PhoneNumberValidator
+    with pytest.raises(ValidationError):
+        MyPhoneRegister.model_validate({"phone": phone})