move collaborative flag to metadata instead of runtime

Author: sanderegg

packages/models-library/src/models_library/service_settings_labels.py

@@ -372,16 +372,6 @@ class DynamicSidecarServiceLabels(BaseModel):
         ),
     ] = None
 
-    is_collaborative: Annotated[
-        bool,
-        Field(
-            alias="simcore.service.is-collaborative",
-            description=(
-                "if True, the service is collaborative and will not be locked"
-            ),
-        ),
-    ] = False
-
     compose_spec: Annotated[
         Json[ComposeSpecLabelDict | None] | None,
         Field(
@@ -673,7 +663,6 @@ def _update_json_schema_extra(schema: JsonDict) -> None:
                         "simcore.service.user-preferences-path": json_dumps(
                             "/tmp/path_to_preferences"  # noqa: S108
                         ),
-                        "simcore.service.is_collaborative": "False",
                     },
                     # dynamic-service with compose spec
                     {
@@ -713,7 +702,6 @@ def _update_json_schema_extra(schema: JsonDict) -> None:
                         "simcore.service.callbacks-mapping": json_dumps(
                             CallbacksMapping.model_json_schema()["examples"][3]
                         ),
-                        "simcore.service.is_collaborative": "True",
                     },
                 ]
             },

packages/models-library/src/models_library/services_metadata_published.py

@@ -84,6 +84,7 @@
         ][1],
     },
     "min-visible-inputs": 2,
+    "is-collaborative": True,
 }
 
 

packages/service-integration/src/service_integration/osparc_config.py

@@ -213,8 +213,6 @@ class RuntimeConfig(BaseModel):
 
     paths_mapping: PathMappingsLabel | None = None
 
-    is_collaborative: bool = False
-
     user_preferences_path: Path | None = None
     boot_options: BootOptions | None = None
     min_visible_inputs: NonNegativeInt | None = None

services/director-v2/src/simcore_service_director_v2/models/dynamic_services_scheduler.py

@@ -406,8 +406,6 @@ def endpoint(self) -> AnyHttpUrl:
 
     paths_mapping: PathMappingsLabel  # overwrites in DynamicSidecarServiceLabels
 
-    is_collaborative: bool = False
-
     user_preferences_path: Path | None = None
     callbacks_mapping: Annotated[CallbacksMapping, Field(default_factory=dict)]
 
@@ -515,7 +513,6 @@ def from_http_request(
             "product_name": service.product_name,
             "product_api_base_url": service.product_api_base_url,
             "paths_mapping": simcore_service_labels.paths_mapping,
-            "is_collaborative": simcore_service_labels.is_collaborative,
             "callbacks_mapping": simcore_service_labels.callbacks_mapping,
             "compose_spec": json_dumps(simcore_service_labels.compose_spec),
             "container_http_entry": simcore_service_labels.container_http_entry,