@pcrespov review: renamed init_app to create_app repo-wide

Author: sanderegg

services/api-server/src/simcore_service_api_server/core/application.py

@@ -48,7 +48,7 @@ def _label_title_and_version(settings: ApplicationSettings, title: str, version:
     return title, version
 
 
-def init_app(settings: ApplicationSettings | None = None) -> FastAPI:
+def create_app(settings: ApplicationSettings | None = None) -> FastAPI:
     if settings is None:
         settings = ApplicationSettings.create_from_envs()
         _logger.info(

services/api-server/src/simcore_service_api_server/main.py

@@ -6,7 +6,7 @@
 from common_library.json_serialization import json_dumps
 from fastapi import FastAPI
 from servicelib.fastapi.logging_lifespan import setup_logging_shutdown_event
-from simcore_service_api_server.core.application import init_app
+from simcore_service_api_server.core.application import create_app
 from simcore_service_api_server.core.settings import ApplicationSettings
 
 _logger = logging.getLogger(__name__)
@@ -33,6 +33,6 @@ def app_factory() -> FastAPI:
         "Application settings: %s",
         json_dumps(app_settings, indent=2, sort_keys=True),
     )
-    app = init_app(settings=app_settings)
+    app = create_app(settings=app_settings)
     app.add_event_handler("shutdown", logging_shutdown_event)
     return app

services/api-server/tests/unit/_with_db/conftest.py

@@ -34,7 +34,7 @@
 from simcore_postgres_database.models.products import products
 from simcore_postgres_database.models.users import users
 from simcore_service_api_server.clients.postgres import get_engine
-from simcore_service_api_server.core.application import init_app
+from simcore_service_api_server.core.application import create_app
 from simcore_service_api_server.core.settings import PostgresSettings
 from sqlalchemy.ext.asyncio import AsyncEngine
 
@@ -187,7 +187,7 @@ def app(app_environment: EnvVarsDict, migrated_db: None) -> FastAPI:
     - it uses default environ as pg
     - db is started and initialized
     """
-    return init_app()
+    return create_app()
 
 
 @pytest.fixture

services/api-server/tests/unit/conftest.py

@@ -54,7 +54,7 @@
 from pytest_simcore.simcore_webserver_projects_rest_api import GET_PROJECT
 from requests.auth import HTTPBasicAuth
 from respx import MockRouter
-from simcore_service_api_server.core.application import init_app
+from simcore_service_api_server.core.application import create_app
 from simcore_service_api_server.core.settings import ApplicationSettings
 from simcore_service_api_server.repository.api_keys import UserAndProductTuple
 from simcore_service_api_server.services_http.solver_job_outputs import ResultsTypes
@@ -131,7 +131,7 @@ def app(
 
         patch_lrt_response_urls()
 
-    return init_app()
+    return create_app()
 
 
 MAX_TIME_FOR_APP_TO_STARTUP = 10

services/director-v2/src/simcore_service_director_v2/core/application.py

@@ -154,7 +154,7 @@ def create_base_app(
     return app
 
 
-def init_app(  # noqa: C901, PLR0912
+def create_app(  # noqa: C901, PLR0912
     settings: AppSettings | None = None,
 ) -> FastAPI:
     app = create_base_app(settings)

services/director-v2/src/simcore_service_director_v2/main.py

@@ -3,10 +3,10 @@
 import logging
 
 from fastapi import FastAPI
-from simcore_service_director_v2.core.application import init_app
+from simcore_service_director_v2.core.application import create_app
 
 _logger = logging.getLogger(__name__)
 
 
 def app_factory() -> FastAPI:
-    return init_app()
+    return create_app()

services/director-v2/tests/conftest.py

@@ -32,7 +32,7 @@
 from pytest_simcore.helpers.typing_env import EnvVarsDict
 from servicelib.rabbitmq import RabbitMQRPCClient
 from settings_library.rabbit import RabbitSettings
-from simcore_service_director_v2.core.application import init_app
+from simcore_service_director_v2.core.application import create_app
 from simcore_service_director_v2.core.settings import AppSettings
 from starlette.testclient import ASGI3App, TestClient
 
@@ -202,7 +202,7 @@ def mock_env(
 @pytest.fixture()
 async def initialized_app(mock_env: EnvVarsDict) -> AsyncIterable[FastAPI]:
     settings = AppSettings.create_from_envs()
-    app = init_app(settings)
+    app = create_app(settings)
     print("Application settings\n", settings.model_dump_json(indent=2))
     async with LifespanManager(app):
         yield app
@@ -213,7 +213,7 @@ async def client(mock_env: EnvVarsDict) -> AsyncIterator[TestClient]:
     # NOTE: this way we ensure the events are run in the application
     # since it starts the app on a test server
     settings = AppSettings.create_from_envs()
-    app = init_app(settings)
+    app = create_app(settings)
     # NOTE: we cannot use the initialized_app fixture here as the TestClient also creates it
     print("Application settings\n", settings.model_dump_json(indent=2))
     with TestClient(app, raise_server_exceptions=True) as test_client:

services/director-v2/tests/integration/02/test_dynamic_services_routes.py

@@ -36,7 +36,7 @@
 )
 from settings_library.rabbit import RabbitSettings
 from settings_library.redis import RedisSettings
-from simcore_service_director_v2.core.application import init_app
+from simcore_service_director_v2.core.application import create_app
 from simcore_service_director_v2.core.settings import AppSettings
 from tenacity.asyncio import AsyncRetrying
 from tenacity.retry import retry_if_exception_type
@@ -197,7 +197,7 @@ async def director_v2_client(
 
     settings = AppSettings.create_from_envs()
 
-    app = init_app(settings)
+    app = create_app(settings)
 
     async with TestClient(app) as client:
         yield client

services/director-v2/tests/unit/test_modules_dask_clients_pool.py

@@ -22,7 +22,7 @@
 )
 from pytest_mock.plugin import MockerFixture
 from pytest_simcore.helpers.typing_env import EnvVarsDict
-from simcore_service_director_v2.core.application import init_app
+from simcore_service_director_v2.core.application import create_app
 from simcore_service_director_v2.core.errors import (
     ConfigurationError,
     DaskClientAcquisisitonError,
@@ -54,7 +54,7 @@ def test_dask_clients_pool_missing_raises_configuration_error(
 ):
     monkeypatch.setenv("COMPUTATIONAL_BACKEND_DASK_CLIENT_ENABLED", "0")
     settings = AppSettings.create_from_envs()
-    app = init_app(settings)
+    app = create_app(settings)
 
     with TestClient(app, raise_server_exceptions=True):  # noqa: SIM117
         with pytest.raises(ConfigurationError):
@@ -70,7 +70,7 @@ def test_dask_clients_pool_properly_setup_and_deleted(
     )
     mocked_dask_clients_pool.create.return_value = mocked_dask_clients_pool
     settings = AppSettings.create_from_envs()
-    app = init_app(settings)
+    app = create_app(settings)
 
     with TestClient(app, raise_server_exceptions=True):
         mocked_dask_clients_pool.create.assert_called_once()