Skip to content

Commit 31c5082

Browse files
committed
Bugfixes
1 parent 7f26d3b commit 31c5082

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

services/catalog/src/simcore_service_catalog/core/background_tasks.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ def _by_version(t: tuple[ServiceKey, ServiceVersion]) -> Version:
9090

9191
# set the service in the DB
9292
_is_legacy_dynamic_service: bool = (
93-
service_metadata.inputs_path is not None
94-
and ervice_metadata.outputs_path is not None
95-
and service_metadata.state_paths is not None
93+
service_metadata.inputs_path is None
94+
and service_metadata.outputs_path is None
95+
and service_metadata.state_paths is None
9696
)
9797
await services_repo.create_or_update_service(
9898
ServiceMetaDataDBCreate(

services/director/src/simcore_service_director/registry_proxy.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,11 +412,15 @@ async def get_image_details(
412412
for key in labels:
413413
if not key.startswith("io.simcore.") and not key.startswith(
414414
"simcore.service."
415-
): # This adds input_paths, output_paths, state_paths
415+
): # Keeping "simcore.service." adds additonally input_paths, output_paths, state_paths
416416
continue
417417
try:
418418
label_data = json.loads(labels[key])
419419
for label_key in label_data:
420+
if isinstance(
421+
label_key, dict
422+
): # Dicts from "simcore.service." docker image labels are omitted.
423+
continue
420424
image_details[label_key] = label_data[label_key]
421425
except json.decoder.JSONDecodeError:
422426
logging.exception(

0 commit comments

Comments
 (0)