♻️ Greenify pylint (after Pydantic v2 migration) (#6747)

Author: giancarloromeo

packages/aws-library/src/aws_library/s3/_errors.py

@@ -10,25 +10,20 @@ class S3NotConnectedError(S3RuntimeError):
 
 
 class S3AccessError(S3RuntimeError):
-    code = "s3_access.error"    # type: ignore[assignment]
     msg_template: str = "Unexpected error while accessing S3 backend"
 
 
 class S3BucketInvalidError(S3AccessError):
-    code = "s3_bucket.invalid_error"    # type: ignore[assignment]
     msg_template: str = "The bucket '{bucket}' is invalid"
 
 
 class S3KeyNotFoundError(S3AccessError):
-    code = "s3_key.not_found_error" # type: ignore[assignment]
     msg_template: str = "The file {key}  in {bucket} was not found"
 
 
 class S3UploadNotFoundError(S3AccessError):
-    code = "s3_upload.not_found_error"  # type: ignore[assignment]
     msg_template: str = "The upload for {key}  in {bucket} was not found"
 
 
 class S3DestinationNotEmptyError(S3AccessError):
-    code = "s3_destination.not_empty_error" # type: ignore[assignment]
     msg_template: str = "The destination {dst_prefix} is not empty"

packages/common-library/tests/test_errors_classes.py

@@ -49,12 +49,10 @@ class MyValueError(MyBaseError, ValueError):
     assert f"{error}" == "Wrong value 42"
 
     class MyTypeError(MyBaseError, TypeError):
-        code = "i_want_this"
         msg_template = "Wrong type {type}"
 
     error = MyTypeError(type="int")
 
-    assert error.code == "i_want_this"
     assert f"{error}" == "Wrong type int"
 
 

packages/dask-task-models-library/src/dask_task_models_library/container_tasks/errors.py

@@ -5,16 +5,14 @@
 
 
 class TaskValueError(OsparcErrorMixin, ValueError):
-    code = "task.value_error"  # type: ignore[assignment]
+    ...
 
 
 class TaskCancelledError(OsparcErrorMixin, RuntimeError):
-    code = "task.cancelled_error"  # type: ignore[assignment]
     msg_template = "The task was cancelled"
 
 
 class ServiceRuntimeError(OsparcErrorMixin, RuntimeError):
-    code = "service.runtime_error"  # type: ignore[assignment]
     msg_template = (
         "The service {service_key}:{service_version}"
         " running in container {container_id} failed with code"

packages/pytest-simcore/src/pytest_simcore/helpers/httpx_calls_capture_parameters.py

@@ -66,14 +66,14 @@ def regex_pattern(self) -> str:
         if self.oneOf:
             msg = "Current version cannot compute regex patterns in case of oneOf. Please go ahead and implement it yourself."
             raise NotImplementedError(msg)
-        if self.anyOf:
+        if self.anyOf is not None:
             return "|".join(
                 [
                     elm.regex_pattern
                     for elm in self.anyOf  # pylint:disable=not-an-iterable
                 ]
             )
-        if self.allOf:
+        if self.allOf is not None:
             return "&".join(
                 [
                     elm.regex_pattern

packages/simcore-sdk/src/simcore_sdk/node_ports_v2/port_validation.py

@@ -23,7 +23,6 @@
 
 
 class PortValueError(OsparcErrorMixin, ValueError):
-    code = "port_validation.schema_error"   # type: ignore
     msg_template = "Invalid value in port {port_key!r}: {schema_error_message}"
 
     # pylint: disable=useless-super-delegation
@@ -38,7 +37,6 @@ def __init__(self, *, port_key: str, schema_error: JsonSchemaValidationError):
 
 
 class PortUnitError(OsparcErrorMixin, ValueError):
-    code = "port_validation.unit_error" # type: ignore
     msg_template = "Invalid unit in port {port_key!r}: {pint_error_msg}"
 
     # pylint: disable=useless-super-delegation

services/director-v2/src/simcore_service_director_v2/core/errors.py

@@ -167,17 +167,13 @@ def get_errors(self) -> list[ErrorDict]:
 class MissingComputationalResourcesError(TaskSchedulingError):
     """A task cannot be scheduled because the cluster does not have the required resources"""
 
-    code = "scheduler_error.missing_resources"
-
     def __init__(self, project_id: ProjectID, node_id: NodeID, msg: str | None = None):
         super().__init__(project_id, node_id, msg=msg)
 
 
 class InsuficientComputationalResourcesError(TaskSchedulingError):
     """A task cannot be scheduled because the cluster does not have *enough* of the required resources"""
 
-    code = "scheduler_error.insuficient_resources"
-
     def __init__(self, project_id: ProjectID, node_id: NodeID, msg: str | None = None):
         super().__init__(project_id, node_id, msg=msg)
 

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/errors.py

@@ -40,5 +40,4 @@ class LegacyServiceIsNotSupportedError(DirectorError):
 
 
 class UnexpectedContainerStatusError(OsparcErrorMixin, DynamicSidecarError):
-    code = "dynamic_sidecar.container_status"   # type: ignore
     msg_template = "Unexpected status from containers: {containers_with_error}"

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/errors.py

@@ -2,4 +2,4 @@
 
 
 class BaseDynamicSchedulerError(OsparcErrorMixin, ValueError):
-    code = "simcore.service.dynamic.scheduler"  # type:ignore[assignment]
+    ...

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/errors.py

@@ -36,7 +36,7 @@ def __init__(self, message: str, status_code: int) -> None:
 
 
 class BaseError(OsparcErrorMixin, BaseDynamicSidecarError):
-    code = "dy_sidecar.error"  # type: ignore[assignment]
+    ...
 
 
 class ContainerExecContainerNotFoundError(BaseError):

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/user_services_preferences/_errors.py

@@ -2,7 +2,7 @@
 
 
 class BaseServicesPreferencesError(OsparcErrorMixin, Exception):
-    code = "dynamic_sidecar.user_service_preferences"  # type: ignore[assignment]
+    ...
 
 
 class DestinationIsNotADirectoryError(BaseServicesPreferencesError):