tests are finally working as expected

Author: Andrei Neagu

…routes_internal_scheduler/test__index.py …outes_internal_scheduler/test__index_.pyservices/dynamic-scheduler/tests/unit/api_frontend/routes_internal_scheduler/test__index.py renamed to services/dynamic-scheduler/tests/unit/api_frontend/_routes_internal_scheduler/test__index_.py services/dynamic-scheduler/tests/unit/api_frontend/routes_internal_scheduler/test__index.py renamed to services/dynamic-scheduler/tests/unit/api_frontend/_routes_internal_scheduler/test__index_.py

@@ -1,8 +1,7 @@
 # pylint:disable=redefined-outer-name
 # pylint:disable=unused-argument
 
-
-from fastapi import FastAPI
+import pytest
 from helpers import assert_contains_text
 from playwright.async_api import Page
 from simcore_service_dynamic_scheduler.api.frontend._utils import get_settings
@@ -18,11 +17,9 @@
 ]
 
 
+@pytest.mark.parametrize("use_internal_scheduler", [True])
 async def test_placeholder_index(
-    app_runner: None,
-    async_page: Page,
-    server_host_port: str,
-    not_initialized_app: FastAPI,
+    app_runner: None, async_page: Page, server_host_port: str
 ):
     await async_page.goto(
         f"{server_host_port}{get_settings().DYNAMIC_SCHEDULER_UI_MOUNT_PATH}"

services/dynamic-scheduler/tests/unit/api_frontend/conftest.py

@@ -6,7 +6,6 @@
 from collections.abc import AsyncIterable
 from contextlib import suppress
 
-import nicegui
 import pytest
 import sqlalchemy as sa
 from fastapi import FastAPI, status
@@ -37,21 +36,19 @@ def disable_status_monitor_background_task(mocker: MockerFixture) -> None:
 def app_environment(
     monkeypatch: pytest.MonkeyPatch,
     app_environment: EnvVarsDict,
-    use_internal_scheduler: bool,  # defined in conftest inside subdirectiories of this module
+    use_internal_scheduler: bool,  # has to be added to every test
     postgres_db: sa.engine.Engine,
     postgres_host_config: PostgresTestConfig,
     disable_status_monitor_background_task: None,
     rabbit_service: RabbitSettings,
     redis_service: RedisSettings,
     remove_redis_data: None,
 ) -> EnvVarsDict:
-    setenvs_from_dict(
-        monkeypatch,
-        {
-            "DYNAMIC_SCHEDULER_USE_INTERNAL_SCHEDULER": f"{use_internal_scheduler}",
-        },
-    )
-    return app_environment
+    to_set = {
+        "DYNAMIC_SCHEDULER_USE_INTERNAL_SCHEDULER": f"{use_internal_scheduler}",
+    }
+    setenvs_from_dict(monkeypatch, to_set)
+    return {**app_environment, **to_set}
 
 
 @pytest.fixture
@@ -62,8 +59,59 @@ def server_host_port() -> str:
 @pytest.fixture
 def not_initialized_app(app_environment: EnvVarsDict) -> FastAPI:
     # forces rebuild of middleware stack on next test
-    nicegui.app.user_middleware.clear()
+    import importlib
+
+    import nicegui
+    from nicegui import Client, binding, core, run
+    from nicegui.page import page
+    from starlette.routing import Route
+
+    for route in list(nicegui.app.routes):
+        if isinstance(route, Route) and route.path.startswith("/_nicegui/auto/static/"):
+            nicegui.app.remove_route(route.path)
+
+    all_page_routes = set(Client.page_routes.values())
+    all_page_routes.add("/")
+    for path in all_page_routes:
+        nicegui.app.remove_route(path)
+
+    for route in list(nicegui.app.routes):
+        if (
+            isinstance(route, Route)
+            and "{" in route.path
+            and "}" in route.path
+            and not route.path.startswith("/_nicegui/")
+        ):
+            nicegui.app.remove_route(route.path)
+
+    nicegui.app.openapi_schema = None
     nicegui.app.middleware_stack = None
+    nicegui.app.user_middleware.clear()
+    nicegui.app.urls.clear()
+    core.air = None
+    # # NOTE favicon routes must be removed separately because they are not "pages"
+    # for route in list(nicegui.app.routes):
+    #     if isinstance(route, Route) and route.path.endswith('/favicon.ico'):
+    #         nicegui.app.routes.remove(route)
+
+    importlib.reload(core)
+    importlib.reload(run)
+
+    Client.instances.clear()
+    Client.page_routes.clear()
+    nicegui.app.reset()
+
+    # Client.auto_index_client = Client(
+    #     page("/"), request=None
+    # ).__enter__()  # pylint: disable=unnecessary-dunder-call
+    # Client.auto_index_client.layout.parent_slot = (
+    #     None  # NOTE: otherwise the layout is nested in the previous client
+    # )
+    # # NOTE we need to re-add the auto index route because we removed all routes above
+    # nicegui.app.get("/")(Client.auto_index_client.build_response)
+
+    binding.reset()
+
     return create_app()
 
 
@@ -118,6 +166,15 @@ def download_playwright_browser() -> None:
 async def async_page(download_playwright_browser: None) -> AsyncIterable[Page]:
     async with async_playwright() as p:
         browser = await p.chromium.launch()
-        page = await browser.new_page()
+        # Create a new incognito context (no shared cache/cookies)
+        context = await browser.new_context()
+        page = await context.new_page()
+        # Optional: Intercept requests to forcibly disable cache
+        await page.route(
+            "**/*",
+            lambda route, request: route.continue_(
+                headers={**request.headers, "Cache-Control": "no-store"}
+            ),
+        )
         yield page
         await browser.close()

services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/conftest.py

@@ -11,11 +11,6 @@
 )
 
 
-@pytest.fixture
-def use_internal_scheduler() -> bool:
-    return False
-
-
 @pytest.fixture
 def mock_stop_dynamic_service(mocker: MockerFixture) -> AsyncMock:
     async_mock = AsyncMock()

services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/test__index.py

@@ -42,6 +42,7 @@
 ]
 
 
+@pytest.mark.parametrize("use_internal_scheduler", [False])
 async def test_index_with_elements(
     app_runner: None,
     async_page: Page,
@@ -69,6 +70,7 @@ async def test_index_with_elements(
     await assert_contains_text(async_page, "Details", instances=2)
 
 
+@pytest.mark.parametrize("use_internal_scheduler", [False])
 @pytest.mark.parametrize(
     "service_status",
     [

services/dynamic-scheduler/tests/unit/api_frontend/routes_external_scheduler/test__service.py

@@ -38,6 +38,7 @@
 ]
 
 
+@pytest.mark.parametrize("use_internal_scheduler", [False])
 async def test_service_details_no_status_present(
     app_runner: None,
     async_page: Page,
@@ -66,6 +67,7 @@ async def test_service_details_no_status_present(
     await assert_contains_text(async_page, "Remove from tracking", instances=1)
 
 
+@pytest.mark.parametrize("use_internal_scheduler", [False])
 async def test_service_details_renders_friendly_404(
     app_runner: None, async_page: Page, server_host_port: str, node_id: NodeID
 ):
@@ -75,6 +77,7 @@ async def test_service_details_renders_friendly_404(
     await assert_contains_text(async_page, "Sorry could not find any details for")
 
 
+@pytest.mark.parametrize("use_internal_scheduler", [False])
 @pytest.mark.parametrize(
     "service_status",
     [