@GitHK review: annotations

Author: pcrespov

services/web/server/src/simcore_service_webserver/projects/_crud_handlers.py

@@ -172,6 +172,27 @@ async def create_project(request: web.Request):
     )
 
 
+def _create_page_response(projects, request_url, total, limit, offset) -> web.Response:
+    page = Page[ProjectListItem].model_validate(
+        paginate_data(
+            chunk=[
+                ProjectListItem.from_domain_model(prj).model_dump(
+                    by_alias=True, exclude_unset=True
+                )
+                for prj in projects
+            ],
+            request_url=request_url,
+            total=total,
+            limit=limit,
+            offset=offset,
+        )
+    )
+    return web.Response(
+        text=page.model_dump_json(**RESPONSE_MODEL_POLICY),
+        content_type=MIMETYPE_APPLICATION_JSON,
+    )
+
+
 @routes.get(f"/{VTAG}/projects", name="list_projects")
 @login_required
 @permission_required("project.read")
@@ -212,23 +233,12 @@ async def list_projects(request: web.Request):
         order_by=OrderBy.model_construct(**query_params.order_by.model_dump()),
     )
 
-    page = Page[ProjectListItem].model_validate(
-        paginate_data(
-            chunk=[
-                ProjectListItem.from_domain_model(prj).model_dump(
-                    by_alias=True, exclude_unset=True
-                )
-                for prj in projects
-            ],
-            request_url=request.url,
-            total=total_number_of_projects,
-            limit=query_params.limit,
-            offset=query_params.offset,
-        )
-    )
-    return web.Response(
-        text=page.model_dump_json(**RESPONSE_MODEL_POLICY),
-        content_type=MIMETYPE_APPLICATION_JSON,
+    return _create_page_response(
+        projects=projects,
+        request_url=request.url,
+        total=total_number_of_projects,
+        limit=query_params.limit,
+        offset=query_params.offset,
     )
 
 
@@ -259,23 +269,12 @@ async def list_projects_full_search(request: web.Request):
         order_by=OrderBy.model_construct(**query_params.order_by.model_dump()),
     )
 
-    page = Page[ProjectListItem].model_validate(
-        paginate_data(
-            chunk=[
-                ProjectListItem.from_domain_model(prj).model_dump(
-                    by_alias=True, exclude_unset=True
-                )
-                for prj in projects
-            ],
-            request_url=request.url,
-            total=total_number_of_projects,
-            limit=query_params.limit,
-            offset=query_params.offset,
-        )
-    )
-    return web.Response(
-        text=page.model_dump_json(**RESPONSE_MODEL_POLICY),
-        content_type=MIMETYPE_APPLICATION_JSON,
+    return _create_page_response(
+        projects=projects,
+        request_url=request.url,
+        total=total_number_of_projects,
+        limit=query_params.limit,
+        offset=query_params.offset,
     )
 
 

services/web/server/src/simcore_service_webserver/workspaces/_workspaces_repository.py

@@ -33,7 +33,7 @@
 )
 from sqlalchemy import asc, desc, func
 from sqlalchemy.ext.asyncio import AsyncConnection
-from sqlalchemy.sql import select
+from sqlalchemy.sql import Select, select
 
 from ..db.plugin import get_asyncpg_engine
 from .errors import WorkspaceAccessForbiddenError, WorkspaceNotFoundError
@@ -82,7 +82,9 @@ async def create_workspace(
         return Workspace.model_validate(row)
 
 
-def _create_base_select_query(caller_user_id: UserID, product_name: ProductName):
+def _create_base_select_query(
+    caller_user_id: UserID, product_name: ProductName
+) -> Select:
     # any other access
     access_rights_subquery = (
         select(