Make job listing test more complex

Author: wvangeit

services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py

@@ -130,10 +130,8 @@ async def create_study_job(
     user_id: Annotated[PositiveInt, Depends(get_current_user_id)],
     product_name: Annotated[str, Depends(get_product_name)],
     hidden: Annotated[bool, Query()] = True,  # noqa: FBT002
-    x_simcore_parent_project_uuid: ProjectID | None = Header(  # noqa: B008
-        default=None
-    ),
-    x_simcore_parent_node_id: NodeID | None = Header(default=None),  # noqa: B008
+    x_simcore_parent_project_uuid: Annotated[ProjectID | None, Header()] = None,
+    x_simcore_parent_node_id: Annotated[NodeID | None, Header()] = None,
 ) -> Job:
     """
     hidden -- if True (default) hides project from UI

services/api-server/tests/unit/api_functions/test_api_routers_function_jobs.py

@@ -115,47 +115,66 @@ async def test_list_function_jobs(
 
 async def test_list_function_jobs_with_job_id_filter(
     client: AsyncClient,
-    mock_handler_in_functions_rpc_interface: Callable[[str, Any], MockType],
+    mock_handler_in_functions_rpc_interface: Callable[[str], MockType],
     mock_registered_project_function_job: RegisteredProjectFunctionJob,
     user_id: UserID,
     product_name: ProductName,
     auth: httpx.BasicAuth,
 ) -> None:
 
-    mocked_list_function_jobs = mock_handler_in_functions_rpc_interface(
+    PAGE_SIZE = 3
+    TOTAL_SIZE = 10
+
+    def mocked_list_function_jobs(offset: int, limit: int):
+        start = offset
+        end = offset + limit
+        items = [
+            mock_registered_project_function_job
+            for _ in range(start, min(end, TOTAL_SIZE))
+        ]
+        return items, PageMetaInfoLimitOffset(
+            total=TOTAL_SIZE, count=len(items), limit=limit, offset=offset
+        )
+
+    mock_list_function_jobs = mock_handler_in_functions_rpc_interface(
         "list_function_jobs",
-        (
-            [mock_registered_project_function_job for _ in range(3)],
-            PageMetaInfoLimitOffset(total=5, count=3, limit=3, offset=1),
-        ),
-    )
-    response = await client.get(
-        f"{API_VTAG}/function_jobs",
-        params={
-            "function_job_ids": [str(mock_registered_project_function_job.uid)],
-            "limit": 3,
-            "offset": 1,
-        },
-        auth=auth,
-    )
-    mocked_list_function_jobs.assert_called_once_with(
-        ANY,  # Dummy rpc client
-        filter_by_function_job_ids=[mock_registered_project_function_job.uid],
-        filter_by_function_job_collection_id=None,
-        filter_by_function_id=None,
-        pagination_offset=1,
-        pagination_limit=3,
-        product_name=product_name,
-        user_id=user_id,
-    )
-    assert response.status_code == status.HTTP_200_OK
-    data = response.json()["items"]
-    assert len(data) == 3
-    assert (
-        RegisteredProjectFunctionJob.model_validate(data[0])
-        == mock_registered_project_function_job
     )
 
+    mock_list_function_jobs.side_effect = lambda *args, **kwargs: (  # noqa: ARG005
+        mocked_list_function_jobs(
+            kwargs.get("pagination_offset", 0),
+            kwargs.get("pagination_limit", PAGE_SIZE),
+        )
+    )
+    for page in range((TOTAL_SIZE + PAGE_SIZE - 1) // PAGE_SIZE):
+        offset = page * PAGE_SIZE
+        response = await client.get(
+            f"{API_VTAG}/function_jobs",
+            params={
+                "function_job_ids": [str(mock_registered_project_function_job.uid)],
+                "limit": PAGE_SIZE,
+                "offset": offset,
+            },
+            auth=auth,
+        )
+        mock_list_function_jobs.assert_called_with(
+            ANY,  # Dummy rpc client
+            filter_by_function_job_ids=[mock_registered_project_function_job.uid],
+            filter_by_function_job_collection_id=None,
+            filter_by_function_id=None,
+            pagination_offset=offset,
+            pagination_limit=PAGE_SIZE,
+            product_name=product_name,
+            user_id=user_id,
+        )
+        assert response.status_code == status.HTTP_200_OK
+        data = response.json()["items"]
+        assert len(data) == min(PAGE_SIZE, TOTAL_SIZE - offset)
+        assert (
+            RegisteredProjectFunctionJob.model_validate(data[0])
+            == mock_registered_project_function_job
+        )
+
 
 @pytest.mark.parametrize("job_status", ["SUCCESS", "FAILED", "STARTED"])
 async def test_get_function_job_status(