review @pcrespov

Author: matusdrobuliak66

services/web/server/src/simcore_service_webserver/projects/_crud_api_read.py

@@ -96,7 +96,7 @@ async def _aggregate_data_to_projects_from_other_sources(
     return updated_projects
 
 
-async def _convert_db_projects_to_api_projects(
+async def _legacy_convert_db_projects_to_api_projects(
     app: web.Application,
     db,
     db_projects: list,
@@ -191,7 +191,9 @@ async def list_projects(  # pylint: disable=too-many-arguments
         order_by=order_by,
     )
 
-    api_projects = await _convert_db_projects_to_api_projects(app, db, db_projects)
+    api_projects = await _legacy_convert_db_projects_to_api_projects(
+        app, db, db_projects
+    )
 
     final_projects = await _aggregate_data_to_projects_from_other_sources(
         app, db_projects=api_projects, user_id=user_id
@@ -231,7 +233,9 @@ async def list_projects_full_depth(
         order_by=order_by,
     )
 
-    api_projects = await _convert_db_projects_to_api_projects(app, db, db_projects)
+    api_projects = await _legacy_convert_db_projects_to_api_projects(
+        app, db, db_projects
+    )
 
     final_projects = await _aggregate_data_to_projects_from_other_sources(
         app, db_projects=api_projects, user_id=user_id

services/web/server/src/simcore_service_webserver/projects/_projects_repository_legacy.py

@@ -677,10 +677,6 @@ async def list_projects_dicts(  # pylint: disable=too-many-arguments,too-many-st
                     combined_query.offset(offset).limit(limit)
                 )
             ]
-            # async for row in conn.execute(combined_query.offset(offset).limit(limit)):
-            #     ProjectListAtDB.model_validate(row)
-            #     prj: dict[str, Any] = dict(row.items())
-            #     prjs_output.append(prj)
 
             return (
                 prjs_output,
@@ -1258,7 +1254,7 @@ async def remove_tag(
                     project["tags"].remove(tag_id)
                 return convert_to_schema_names(project, user_email)
 
-    async def get_tags_by_project(self, project_id: str) -> list:
+    async def get_tags_by_project(self, project_id: str) -> list[int]:
         async with self.engine.acquire() as conn:
             query = sa.select(projects_tags.c.tag_id).where(
                 projects_tags.c.project_id == project_id