Skip to content

Commit 3632ac8

Browse files
authored
🐛 Prevent showing full s3 url with credentials in logs (#8493)
1 parent b01bc0d commit 3632ac8

File tree

1 file changed

+4
-3
lines changed
  • services/dask-sidecar/src/simcore_service_dask_sidecar/utils

1 file changed

+4
-3
lines changed

services/dask-sidecar/src/simcore_service_dask_sidecar/utils/files.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,9 @@ async def pull_file_from_remote(
166166
s3_settings: S3Settings | None,
167167
) -> None:
168168
assert src_url.path # nosec
169+
src_location_str = f"{src_url.path.strip('/')} on {src_url.host}:{src_url.port}"
169170
await log_publishing_cb(
170-
f"Downloading '{src_url}' into local file '{dst_path}'...",
171+
f"Downloading '{src_location_str}' into local file '{dst_path}'...",
171172
logging.INFO,
172173
)
173174
if not dst_path.parent.exists():
@@ -196,11 +197,11 @@ async def pull_file_from_remote(
196197
TypeAdapter(FileUrl).validate_python(f"{download_dst_path.as_uri()}"),
197198
src_storage_cfg=cast(dict[str, Any], storage_kwargs),
198199
log_publishing_cb=log_publishing_cb,
199-
text_prefix=f"Downloading '{src_url.path.strip('/')}':",
200+
text_prefix=f"Downloading '{src_location_str}':",
200201
)
201202

202203
await log_publishing_cb(
203-
f"Download of '{src_url}' into local file '{download_dst_path}' complete.",
204+
f"Download of '{src_location_str}' into local file '{download_dst_path}' complete.",
204205
logging.INFO,
205206
)
206207

0 commit comments

Comments
 (0)