add prometheus friendly app name

Author: bisgaard-itis

packages/service-library/src/servicelib/utils_meta.py

@@ -50,6 +50,13 @@ def app_name(self) -> str:
         """
         return self._distribution.metadata["Name"]
 
+    @property
+    def prometheus_friendly_app_name(self) -> str:
+        """
+        Returns a version of the app name which is compatible with Prometheus metrics naming conventions (no dashes).
+        """
+        return self.app_name.replace("-", "_")
+
     @property
     def version(self) -> Version:
         return Version(self._distribution.version)

packages/service-library/tests/test_utils_meta.py

@@ -60,6 +60,7 @@ def test_app_name(
         info = PackageInfo(package_name=package_name)
         if is_correct_app_name:
             assert info.app_name == app_name
+            assert info.prometheus_friendly_app_name == app_name.replace("-", "_")
     else:
         with pytest.raises(ValueError):
             _ = PackageInfo(package_name=package_name)

services/web/server/src/simcore_service_webserver/_meta.py

@@ -19,6 +19,7 @@
 
 # legacy consts
 APP_NAME: Final[str] = info.app_name
+PROMETHEUS_FRIENDLY_APP_NAME: Final[str] = info.prometheus_friendly_app_name
 api_version_prefix: str = API_VTAG
 
 

services/web/server/src/simcore_service_webserver/diagnostics/_monitoring.py

@@ -55,7 +55,7 @@ def setup_monitoring(app: web.Application):
     )
 
     monitor_services.add_instrumentation(
-        app, get_collector_registry(app), _meta.APP_NAME
+        app, get_collector_registry(app), _meta.PROMETHEUS_FRIENDLY_APP_NAME
     )
 
     # on-the fly stats