🐛 Frontend Fix: Make sure SelectBox's selection is not null (#5785)

odeimaiz · web-flow · commit 390afe1f1b6e · 2024-05-06T16:05:33.000+02:00
diff --git a/services/static-webserver/client/source/class/osparc/cluster/ClustersDetails.js b/services/static-webserver/client/source/class/osparc/cluster/ClustersDetails.js
@@ -50,8 +50,11 @@ qx.Class.define("osparc.cluster.ClustersDetails", {
       });
       osparc.cluster.Utils.populateClustersSelectBox(selectBox);
       selectBox.addListener("changeSelection", e => {
-        const clusterId = e.getData()[0].id;
-        this.__selectedClusterChanged(clusterId);
+        const selection = e.getData();
+        if (selection.length) {
+          const clusterId = selection[0].id;
+          this.__selectedClusterChanged(clusterId);
+        }
       }, this);
       clustersLayout.add(selectBox);
 
diff --git a/services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js b/services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js
@@ -245,9 +245,9 @@ qx.Class.define("osparc.dashboard.ResourceDetails", {
           });
 
           // then listen to changes
-          versionsBox.addListener("changeSelection", () => {
-            const selection = versionsBox.getSelection();
-            if (selection && selection.length) {
+          versionsBox.addListener("changeSelection", e => {
+            const selection = e.getData();
+            if (selection.length) {
               const serviceVersion = selection[0].getLabel();
               if (serviceVersion !== this.__resourceData["version"]) {
                 const serviceData = osparc.service.Utils.getFromObject(services, this.__resourceData["key"], serviceVersion);
diff --git a/services/static-webserver/client/source/class/osparc/desktop/credits/Usage.js b/services/static-webserver/client/source/class/osparc/desktop/credits/Usage.js
@@ -84,8 +84,9 @@ qx.Class.define("osparc.desktop.credits.Usage", {
       this._add(container);
 
       walletSelectBox.addListener("changeSelection", e => {
-        if (walletSelectBox.getSelection().length) {
-          this.__selectedWallet = walletSelectBox.getSelection()[0].getModel()
+        const selection = e.getData();
+        if (selection.length) {
+          this.__selectedWallet = selection[0].getModel()
           if (this.__table) {
             this.__table.getTableModel().setWalletId(this.__selectedWallet.getWalletId())
             this.__table.getTableModel().reloadData()
diff --git a/services/static-webserver/client/source/class/osparc/desktop/organizations/OrganizationsList.js b/services/static-webserver/client/source/class/osparc/desktop/organizations/OrganizationsList.js
@@ -168,7 +168,7 @@ qx.Class.define("osparc.desktop.organizations.OrganizationsList", {
     },
 
     __organizationSelected: function(data) {
-      if (data && data.length>0) {
+      if (data && data.length) {
         const org = data[0];
         this.fireDataEvent("organizationSelected", org.getModel());
       }
diff --git a/services/static-webserver/client/source/class/osparc/desktop/preferences/pages/ClustersPage.js b/services/static-webserver/client/source/class/osparc/desktop/preferences/pages/ClustersPage.js
@@ -218,7 +218,7 @@ qx.Class.define("osparc.desktop.preferences.pages.ClustersPage", {
 
     __clusterSelected: function(data) {
       this.__selectOrgMemberLayout.exclude();
-      if (data && data.length>0) {
+      if (data && data.length) {
         this.__currentCluster = data[0];
       } else {
         this.__currentCluster = null;
diff --git a/services/static-webserver/client/source/class/osparc/metadata/QualityEditor.js b/services/static-webserver/client/source/class/osparc/metadata/QualityEditor.js
@@ -354,11 +354,14 @@ qx.Class.define("osparc.metadata.QualityEditor", {
             }
           });
           targetsBox.addListener("changeSelection", e => {
-            const newMaxScore = e.getData()[0].level;
-            copyTSRTarget[ruleKey].level = newMaxScore;
-            copyTSRCurrent[ruleKey].level = Math.min(newMaxScore, copyTSRCurrent[ruleKey].level);
-            updateCurrentLevel(copyTSRCurrent[ruleKey].level);
-            updateTotalTSR();
+            const selection = e.getData();
+            if (selection.length) {
+              const newMaxScore = selection[0].level;
+              copyTSRTarget[ruleKey].level = newMaxScore;
+              copyTSRCurrent[ruleKey].level = Math.min(newMaxScore, copyTSRCurrent[ruleKey].level);
+              updateCurrentLevel(copyTSRCurrent[ruleKey].level);
+              updateTotalTSR();
+            }
           }, this);
           this.bind("mode", targetsBox, "visibility", {
             converter: mode => mode === "edit" ? "visible" : "excluded"
diff --git a/services/static-webserver/client/source/class/osparc/metadata/ServicesInStudyBootOpts.js b/services/static-webserver/client/source/class/osparc/metadata/ServicesInStudyBootOpts.js
@@ -85,8 +85,11 @@ qx.Class.define("osparc.metadata.ServicesInStudyBootOpts", {
         if (canIWrite && hasBootModes) {
           const bootModeSB = osparc.data.model.Node.getBootModesSelectBox(nodeMetaData, workbench, nodeId);
           bootModeSB.addListener("changeSelection", e => {
-            const newBootModeId = e.getData()[0].bootModeId;
-            this.__updateBootMode(nodeId, newBootModeId);
+            const selection = e.getData();
+            if (selection.length) {
+              const newBootModeId = e.getData()[0].bootModeId;
+              this.__updateBootMode(nodeId, newBootModeId);
+            }
           }, this);
           this._servicesGrid.add(bootModeSB, {
             row: i,
diff --git a/services/static-webserver/client/source/class/osparc/node/BootOptionsView.js b/services/static-webserver/client/source/class/osparc/node/BootOptionsView.js
@@ -54,16 +54,19 @@ qx.Class.define("osparc.node.BootOptionsView", {
         converter: interactive => interactive === "idle"
       });
       bootModeSB.addListener("changeSelection", e => {
-        buttonsLayout.setEnabled(false);
-        const newBootModeId = e.getData()[0].bootModeId;
-        node.setBootOptions({
-          "boot_mode": newBootModeId
-        });
-        setTimeout(() => {
-          buttonsLayout.setEnabled(true);
-          node.requestStartNode();
-          this.fireEvent("bootModeChanged");
-        }, osparc.desktop.StudyEditor.AUTO_SAVE_INTERVAL*2);
+        const selection = e.getData();
+        if (selection.length) {
+          buttonsLayout.setEnabled(false);
+          const newBootModeId = selection[0].bootModeId;
+          node.setBootOptions({
+            "boot_mode": newBootModeId
+          });
+          setTimeout(() => {
+            buttonsLayout.setEnabled(true);
+            node.requestStartNode();
+            this.fireEvent("bootModeChanged");
+          }, osparc.desktop.StudyEditor.AUTO_SAVE_INTERVAL*2);
+        }
       }, this);
       buttonsLayout.add(bootModeSB);
 
diff --git a/services/static-webserver/client/source/class/osparc/po/MessageTemplates.js b/services/static-webserver/client/source/class/osparc/po/MessageTemplates.js
@@ -55,8 +55,11 @@ qx.Class.define("osparc.po.MessageTemplates", {
       });
 
       templatesSB.addListener("changeSelection", e => {
-        const templateId = e.getData()[0].getModel();
-        this.__populateMessage(templateId);
+        const selection = e.getData();
+        if (selection.length) {
+          const templateId = selection[0].getModel();
+          this.__populateMessage(templateId);
+        }
       }, this);
       this.__messageTemplates.forEach(template => {
         const lItem = new qx.ui.form.ListItem(template.id, null, template.id);
diff --git a/services/static-webserver/client/source/class/osparc/pricing/Plans.js b/services/static-webserver/client/source/class/osparc/pricing/Plans.js
@@ -58,8 +58,11 @@ qx.Class.define("osparc.pricing.Plans", {
             spacing: 3
           });
           control.addListener("changeSelection", e => {
-            const ppSelected = e.getData()[0];
-            this.fireDataEvent("pricingPlanSelected", ppSelected);
+            const selection = e.getData();
+            if (selection.length) {
+              const ppSelected = selection[0];
+              this.fireDataEvent("pricingPlanSelected", ppSelected);
+            }
           }, this);
           this.getChildControl("pricing-plans-container").add(control);
           break;
diff --git a/services/static-webserver/client/source/class/osparc/study/BillingSettings.js b/services/static-webserver/client/source/class/osparc/study/BillingSettings.js
@@ -78,30 +78,32 @@ qx.Class.define("osparc.study.BillingSettings", {
           .finally(() => {
             walletSelector.addListener("changeSelection", e => {
               const selection = e.getData();
-              const walletId = selection[0].walletId;
-              if (walletId === null) {
-                return;
-              }
-              hBox.setEnabled(false);
-              const paramsPut = {
-                url: {
-                  studyId: this.__studyData["uuid"],
-                  walletId
+              if (selection.length) {
+                const walletId = selection[0].walletId;
+                if (walletId === null) {
+                  return;
                 }
-              };
-              osparc.data.Resources.fetch("studies", "selectWallet", paramsPut)
-                .then(() => {
-                  const msg = this.tr("Credit Account saved");
-                  osparc.FlashMessenger.getInstance().logAs(msg, "INFO");
-                })
-                .catch(err => {
-                  console.error(err);
-                  osparc.FlashMessenger.logAs(err.message, "ERROR");
-                })
-                .finally(() => {
-                  hBox.setEnabled(true);
-                  populateCreditAccountBox();
-                });
+                hBox.setEnabled(false);
+                const paramsPut = {
+                  url: {
+                    studyId: this.__studyData["uuid"],
+                    walletId
+                  }
+                };
+                osparc.data.Resources.fetch("studies", "selectWallet", paramsPut)
+                  .then(() => {
+                    const msg = this.tr("Credit Account saved");
+                    osparc.FlashMessenger.getInstance().logAs(msg, "INFO");
+                  })
+                  .catch(err => {
+                    console.error(err);
+                    osparc.FlashMessenger.logAs(err.message, "ERROR");
+                  })
+                  .finally(() => {
+                    hBox.setEnabled(true);
+                    populateCreditAccountBox();
+                  });
+              }
             });
           });
       };
diff --git a/services/static-webserver/client/source/class/osparc/study/StudyOptions.js b/services/static-webserver/client/source/class/osparc/study/StudyOptions.js
@@ -236,7 +236,9 @@ qx.Class.define("osparc.study.StudyOptions", {
       };
       walletSelector.addListener("changeSelection", e => {
         const selection = e.getData();
-        selectWallet(selection[0].walletId);
+        if (selection.length) {
+          selectWallet(selection[0].walletId);
+        }
       });
       const preferredWallet = store.getPreferredWallet();
       if (wallets.find(wallet => wallet.getWalletId() === parseInt(this.__projectWalletId))) {

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ qx.Class.define("osparc.desktop.organizations.OrganizationsList", {`
`168`	`168`	`},`
`169`	`169`
`170`	`170`	`__organizationSelected: function(data) {`
`171`		`- if (data && data.length>0) {`
	`171`	`+ if (data && data.length) {`
`172`	`172`	`const org = data[0];`
`173`	`173`	`this.fireDataEvent("organizationSelected", org.getModel());`
`174`	`174`	`}`