Skip to content

Commit 396202b

Browse files
authored
🎨 E2E: Handle success value to True when no messages came in (#7603)
1 parent 81be9bc commit 396202b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ def __call__(self, message: str) -> bool:
453453

454454
done = self._completed_successfully()
455455
if done:
456-
self._result = True
456+
self._result = True # NOTE: might have failed but it is not sure. so we set the result to True
457457
self.logger.info("✅ Service start completed successfully!! ✅")
458458
return done
459459

@@ -465,6 +465,7 @@ def __call__(self, message: str) -> bool:
465465
time_since_last_progress,
466466
self.node_id,
467467
)
468+
self._result = True
468469
return True
469470

470471
return False

0 commit comments

Comments
 (0)