refactor

Author: odeimaiz

services/static-webserver/client/source/class/osparc/navigation/NavigationBar.js

@@ -112,19 +112,7 @@ qx.Class.define("osparc.navigation.NavigationBar", {
         converter: s => s ? "visible" : "excluded"
       });
 
-      const savingStudyIcon = this.getChildControl("saving-study-icon");
-      this.bind("study", savingStudyIcon, "visibility", {
-        converter: s => {
-          if (s) {
-            s.addListener("changeSavePending", e => {
-              const isSaving = e.getData();
-              const uiMode = s.getUi().getMode();
-              savingStudyIcon.setVisibility(isSaving && ["workbench", "pipeline"].includes(uiMode) ? "visible" : "excluded");
-            });
-          }
-          return "excluded";
-        }
-      });
+      this.getChildControl("saving-study-icon");
 
       // center-items
       this.getChildControl("read-only-info");
@@ -222,6 +210,7 @@ qx.Class.define("osparc.navigation.NavigationBar", {
             label: this.tr("Saving..."),
             font: "text-12",
             opacity: 0.8,
+            visibility: "excluded",
           });
           this.getChildControl("left-items").add(control);
           break;
@@ -360,13 +349,18 @@ qx.Class.define("osparc.navigation.NavigationBar", {
     },
 
     __applyStudy: function(study) {
+      const savingStudyIcon = this.getChildControl("saving-study-icon");
       const readOnlyInfo = this.getChildControl("read-only-info")
       if (study) {
         this.getChildControl("study-title-options").setStudy(study);
+        study.bind("savePending", readOnlyInfo, "visibility", {
+          converter: value => value && ["workbench", "pipeline"].includes(study.getUi().getMode()) ? "visible" : "excluded"
+        });
         study.bind("readOnly", readOnlyInfo, "visibility", {
           converter: value => value ? "visible" : "excluded"
         });
       } else {
+        savingStudyIcon.exclude();
         readOnlyInfo.exclude();
       }
     },