mypy

Author: sanderegg

packages/service-library/src/servicelib/fastapi/http_error.py

@@ -42,10 +42,10 @@ async def _http_error_handler(_: Request, exc: Exception) -> JSONResponse:
             "errors": error_extractor(exc) if error_extractor else [f"{exc}"]
         }
 
-        if envelope_error:
-            error_content = {"error": error_content}
         return JSONResponse(
-            content=jsonable_encoder(error_content),
+            content=jsonable_encoder(
+                {"error": error_content} if envelope_error else error_content
+            ),
             status_code=status_code,
         )
 
@@ -65,10 +65,11 @@ async def _http_error_handler(_: Request, exc: Exception) -> JSONResponse:
         assert isinstance(exc, HTTPException)
 
         error_content = {"errors": [exc.detail]}
-        if envelope_error:
-            error_content = {"error": error_content}
+
         return JSONResponse(
-            content=jsonable_encoder(error_content),
+            content=jsonable_encoder(
+                {"error": error_content} if envelope_error else error_content
+            ),
             status_code=exc.status_code,
         )