error messages

Author: pcrespov

services/web/server/src/simcore_service_webserver/studies_dispatcher/_errors.py

@@ -8,31 +8,43 @@ class StudyDispatcherError(WebServerBaseError, ValueError): ...
 
 class IncompatibleServiceError(StudyDispatcherError):
     msg_template = user_message(
-        "None of the registered services can handle '{file_type}'"
+        "None of the registered services can handle '{file_type}' files.", _version=1
     )
 
 
 class FileToLargeError(StudyDispatcherError):
-    msg_template = user_message("File size {file_size_in_mb} MB is over allowed limit")
+    msg_template = user_message(
+        "File size {file_size_in_mb} MB exceeds the allowed limit.", _version=1
+    )
 
 
 class ServiceNotFoundError(StudyDispatcherError):
-    msg_template = user_message("Service {service_key}:{service_version} not found")
+    msg_template = user_message(
+        "Service {service_key}:{service_version} could not be found.", _version=1
+    )
 
 
 class InvalidRedirectionParamsError(StudyDispatcherError):
-    msg_template = "Invalid link"
+    msg_template = user_message(
+        "The provided link is invalid or incomplete.", _version=1
+    )
 
 
 class GuestUsersLimitError(StudyDispatcherError):
     msg_template = user_message(
-        "Maximum number of guests was reached. Please login with a registered user or try again later"
+        "Maximum number of guest users has been reached. Please log in with a registered account or try again later.",
+        _version=1,
     )
 
 
 class GuestUserNotAllowedError(StudyDispatcherError):
-    msg_template = "Guest users are not allowed to access this resource configuration."
+    msg_template = user_message(
+        "Guest users are not allowed to access this resource.", _version=1
+    )
 
 
 class ProjectWorkbenchMismatchError(StudyDispatcherError):
-    msg_template = "Project {project_uuid} exists but does not seem to be a viewer generated by this module"
+    msg_template = user_message(
+        "Project {project_uuid} appears to be corrupted and cannot be accessed properly.",
+        _version=1,
+    )

services/web/server/src/simcore_service_webserver/studies_dispatcher/_redirects_handlers.py

@@ -123,12 +123,17 @@ def _create_error_redirect_with_logging(
 
 def _create_simple_error_redirect(
     request: web.Request,
-    err: Exception,
+    public_error: Exception,
     *,
     status_code: int,
 ) -> web.HTTPFound:
-    """Helper to create simple error redirect without logging"""
-    user_error_msg = f"Sorry, we cannot dispatch your study: {err}"
+    """Helper to create simple error redirect without logging
+
+    WARNING: note that the `public_error` is exposed as-is in the user-message
+    """
+    user_error_msg = user_message(
+        f"Unable to open your project: {public_error}", _version=1
+    )
     return _create_redirect_response_to_error_page(
         request.app,
         message=user_error_msg,
@@ -152,7 +157,7 @@ async def wrapper(request: web.Request) -> web.StreamResponse:
                 message=user_message(
                     "Access is restricted to registered users.<br/><br/>"
                     "If you don't have an account, please contact support to request one.<br/><br/>",
-                    _version=1,
+                    _version=2,
                 ),
                 status_code=status.HTTP_401_UNAUTHORIZED,
             ) from err
@@ -184,8 +189,9 @@ async def wrapper(request: web.Request) -> web.StreamResponse:
                 request,
                 err,
                 message=user_message(
-                    "The link you provided is invalid because it doesn't contain any or invalid information related to data or a service."
-                    "Please check the link and make sure it is correct."
+                    "The link you provided is invalid because it doesn't contain valid information related to data or a service. "
+                    "Please check the link and make sure it is correct.",
+                    _version=1,
                 ),
                 status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
                 tip="The link might be corrupted",

services/web/server/tests/unit/with_dbs/04/studies_dispatcher/test_studies_dispatcher_handlers.py

@@ -580,7 +580,7 @@ async def test_viewer_redirect_with_file_type_errors(client: TestClient):
     message, status_code = assert_error_in_fragment(resp)
 
     assert status_code == status.HTTP_422_UNPROCESSABLE_ENTITY
-    assert "type" in message.lower()
+    assert "link" in message.lower()
 
 
 async def test_viewer_redirect_with_client_errors(client: TestClient):

services/web/server/tests/unit/with_dbs/04/studies_dispatcher/test_studies_dispatcher_studies_access.py

@@ -176,7 +176,7 @@ def mocks_on_projects_api(mocker: MockerFixture) -> None:
     """
     import simcore_service_webserver.projects._projects_service
 
-    mocker.patch.patch(
+    mocker.patch.object(
         simcore_service_webserver.projects._projects_service,
         "_get_project_share_state",
         return_value=ProjectShareState(