Skip to content

Commit 3da7e4e

Browse files
fix default sortering
1 parent a9ac3a4 commit 3da7e4e

File tree

6 files changed

+31
-8
lines changed

6 files changed

+31
-8
lines changed

services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/services/modules/db/licensed_items_checkouts_db.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,19 @@ async def list_(
111111
# Ordering and pagination
112112
if order_by.direction == OrderDirection.ASC:
113113
list_query = base_query.order_by(
114-
sa.asc(getattr(resource_tracker_licensed_items_checkouts.c, order_by.field))
114+
sa.asc(
115+
getattr(resource_tracker_licensed_items_checkouts.c, order_by.field)
116+
),
117+
resource_tracker_licensed_items_checkouts.c.licensed_item_checkout_id,
115118
)
116119
else:
117120
list_query = base_query.order_by(
118121
sa.desc(
119-
getattr(resource_tracker_licensed_items_checkouts.c, order_by.field)
122+
getattr(
123+
resource_tracker_licensed_items_checkouts.c,
124+
order_by.field,
125+
resource_tracker_licensed_items_checkouts.c.licensed_item_checkout_id,
126+
)
120127
)
121128
)
122129
list_query = list_query.offset(offset).limit(limit)

services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/services/modules/db/licensed_items_purchases_db.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,17 @@ async def list_(
110110
# Ordering and pagination
111111
if order_by.direction == OrderDirection.ASC:
112112
list_query = base_query.order_by(
113-
sa.asc(getattr(resource_tracker_licensed_items_purchases.c, order_by.field))
113+
sa.asc(
114+
getattr(resource_tracker_licensed_items_purchases.c, order_by.field)
115+
),
116+
resource_tracker_licensed_items_purchases.c.licensed_item_purchase_id,
114117
)
115118
else:
116119
list_query = base_query.order_by(
117120
sa.desc(
118121
getattr(resource_tracker_licensed_items_purchases.c, order_by.field)
119-
)
122+
),
123+
resource_tracker_licensed_items_purchases.c.licensed_item_purchase_id,
120124
)
121125
list_query = list_query.offset(offset).limit(limit)
122126

services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/services/modules/db/pricing_plans_db.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,10 @@ async def list_pricing_plans_by_product(
208208
count_query = sa.select(sa.func.count()).select_from(subquery)
209209

210210
# Default ordering
211-
list_query = base_query.order_by(resource_tracker_pricing_plans.c.created.asc())
211+
list_query = base_query.order_by(
212+
resource_tracker_pricing_plans.c.created.asc(),
213+
resource_tracker_pricing_plans.c.pricing_plan_id,
214+
)
212215

213216
total_count = await conn.scalar(count_query)
214217
if total_count is None:

services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/services/modules/db/service_runs_db.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,10 @@ async def get_osparc_credits_aggregated_by_service(
424424

425425
# Default ordering and pagination
426426
list_query = (
427-
base_query.order_by(resource_tracker_service_runs.c.service_key.asc())
427+
base_query.order_by(
428+
resource_tracker_service_runs.c.service_key.asc(),
429+
resource_tracker_service_runs.c.service_run_id,
430+
)
428431
.offset(offset)
429432
.limit(limit)
430433
)

services/resource-usage-tracker/tests/unit/with_dbs/test_licensed_items_checkouts_db.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ async def test_licensed_items_checkouts_db__force_release_license_seats_by_run_i
7171
# SETUP
7272
_create_license_item_checkout_db_1 = CreateLicensedItemCheckoutDB(
7373
licensed_item_id="beb16d18-d57d-44aa-a638-9727fa4a72ef",
74+
key="Duke",
75+
version="1.0.0",
7476
wallet_id=_WALLET_ID,
7577
user_id=_USER_ID_1,
7678
user_email="[email protected]",

services/web/server/src/simcore_service_webserver/licenses/_licensed_items_repository.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,10 +315,14 @@ async def list_licensed_items(
315315

316316
# Ordering and pagination
317317
if order_by.direction == OrderDirection.ASC:
318-
list_query = base_query.order_by(asc(getattr(licensed_items.c, order_by.field)))
318+
list_query = base_query.order_by(
319+
asc(getattr(licensed_items.c, order_by.field)),
320+
licensed_items.c.licensed_item_id,
321+
)
319322
else:
320323
list_query = base_query.order_by(
321-
desc(getattr(licensed_items.c, order_by.field))
324+
desc(getattr(licensed_items.c, order_by.field)),
325+
licensed_items.c.licensed_item_id,
322326
)
323327
list_query = list_query.offset(offset).limit(limit)
324328

0 commit comments

Comments
 (0)