Skip to content

Commit 3eb722c

Browse files
committed
add logs for broken websockets
1 parent cf2c025 commit 3eb722c

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

tests/e2e-playwright/tests/sim4life/test_sim4life.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@
1111
from typing import Any
1212

1313
from playwright.sync_api import Page, WebSocket
14-
from pytest_simcore.helpers.playwright import ServiceType
14+
from pytest_simcore.helpers.playwright import (
15+
ServiceType,
16+
web_socket_default_log_handler,
17+
)
1518
from pytest_simcore.helpers.playwright_sim4life import (
1619
check_video_streaming,
1720
interact_with_s4l,
@@ -49,8 +52,9 @@ def test_sim4life(
4952
page, node_ids[0], log_in_and_out, autoscaled=autoscaled, copy_workspace=False
5053
)
5154
s4l_websocket = resp["websocket"]
52-
s4l_iframe = resp["iframe"]
53-
interact_with_s4l(page, s4l_iframe)
55+
with web_socket_default_log_handler(s4l_websocket):
56+
s4l_iframe = resp["iframe"]
57+
interact_with_s4l(page, s4l_iframe)
5458

55-
if check_videostreaming:
56-
check_video_streaming(page, s4l_iframe, s4l_websocket)
59+
if check_videostreaming:
60+
check_video_streaming(page, s4l_iframe, s4l_websocket)

tests/e2e-playwright/tests/sim4life/test_template.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from typing import Any
1212

1313
from playwright.sync_api import Page, WebSocket
14+
from pytest_simcore.helpers.playwright import web_socket_default_log_handler
1415
from pytest_simcore.helpers.playwright_sim4life import (
1516
check_video_streaming,
1617
interact_with_s4l,
@@ -39,8 +40,9 @@ def test_template(
3940
page, node_ids[0], log_in_and_out, autoscaled=autoscaled, copy_workspace=True
4041
)
4142
s4l_websocket = resp["websocket"]
42-
s4l_iframe = resp["iframe"]
43-
interact_with_s4l(page, s4l_iframe)
43+
with web_socket_default_log_handler(s4l_websocket):
44+
s4l_iframe = resp["iframe"]
45+
interact_with_s4l(page, s4l_iframe)
4446

45-
if check_videostreaming:
46-
check_video_streaming(page, s4l_iframe, s4l_websocket)
47+
if check_videostreaming:
48+
check_video_streaming(page, s4l_iframe, s4l_websocket)

0 commit comments

Comments
 (0)