Handles support conversations without project ID

Allows support conversations and messages to be created, updated, and deleted without requiring a project ID.

Prevents unnecessary notifications for support conversations by skipping events when no project ID is present.

Improves access control checks and context handling for support-type conversations.

Enhances code clarity and robustness for support workflows.

Author: matusdrobuliak66

packages/models-library/src/models_library/api_schemas_webserver/conversations.py

@@ -28,6 +28,7 @@ class ConversationRestGet(OutputSchema):
     type: ConversationType
     created: datetime
     modified: datetime
+    extra_context: dict[str, str]
 
     @classmethod
     def from_domain_model(cls, domain: ConversationGetDB) -> Self:
@@ -40,6 +41,7 @@ def from_domain_model(cls, domain: ConversationGetDB) -> Self:
             type=domain.type,
             created=domain.created,
             modified=domain.modified,
+            extra_context=domain.extra_context,
         )
 
 

services/web/server/src/simcore_service_webserver/conversations/_controller/conversations_rest.py

@@ -65,7 +65,7 @@ class _GetConversationsQueryParams(BaseModel):
     type: ConversationType
     model_config = ConfigDict(extra="forbid")
 
-    @field_validator('type')
+    @field_validator("type")
     @classmethod
     def validate_type(cls, value):
         if value is not None and value != ConversationType.SUPPORT:
@@ -101,7 +101,9 @@ async def create_conversation(request: web.Request):
     """Create a new conversation (supports only type='support')"""
     try:
         req_ctx = AuthenticatedRequestContext.model_validate(request)
-        body_params = await parse_request_body_as(_ConversationsCreateBodyParams, request)
+        body_params = await parse_request_body_as(
+            _ConversationsCreateBodyParams, request
+        )
 
         # Ensure only support conversations are allowed
         if body_params.type != ConversationType.SUPPORT:
@@ -126,7 +128,9 @@ async def create_conversation(request: web.Request):
         raise
     except Exception as exc:
         _logger.exception("Failed to create conversation")
-        raise web.HTTPInternalServerError(reason="Failed to create conversation") from exc
+        raise web.HTTPInternalServerError(
+            reason="Failed to create conversation"
+        ) from exc
 
 
 @routes.get(
@@ -169,7 +173,9 @@ async def list_conversations(request: web.Request):
 
     except Exception as exc:
         _logger.exception("Failed to list conversations")
-        raise web.HTTPInternalServerError(reason="Failed to list conversations") from exc
+        raise web.HTTPInternalServerError(
+            reason="Failed to list conversations"
+        ) from exc
 
 
 @routes.get(
@@ -180,16 +186,17 @@ async def list_conversations(request: web.Request):
 async def get_conversation(request: web.Request):
     """Get a specific conversation"""
     try:
+        req_ctx = AuthenticatedRequestContext.model_validate(request)
         path_params = parse_request_path_parameters_as(_ConversationPathParams, request)
         query_params = parse_request_query_parameters_as(
             _GetConversationsQueryParams, request
         )
-
-        # I need to check whether I have access to that conversation?
+        assert query_params.type == ConversationType.SUPPORT  # nosec
 
         conversation = await get_support_conversation_for_user(
             app=request.app,
-            user_id=
+            user_id=req_ctx.user_id,
+            product_name=req_ctx.product_name,
             conversation_id=path_params.conversation_id,
         )
 
@@ -209,17 +216,25 @@ async def get_conversation(request: web.Request):
 async def update_conversation(request: web.Request):
     """Update a conversation"""
     try:
+        req_ctx = AuthenticatedRequestContext.model_validate(request)
         path_params = parse_request_path_parameters_as(_ConversationPathParams, request)
         body_params = await parse_request_body_as(ConversationPatch, request)
+        query_params = parse_request_query_parameters_as(
+            _GetConversationsQueryParams, request
+        )
 
-        # For support conversations, we need a dummy project_id since the service requires it
-        # but for support conversations it won't be used
-        from uuid import uuid4
-        dummy_project_id = uuid4()  # This won't be used for support conversations
+        assert query_params.type == ConversationType.SUPPORT  # nosec
+
+        await get_support_conversation_for_user(
+            app=request.app,
+            user_id=req_ctx.user_id,
+            product_name=req_ctx.product_name,
+            conversation_id=path_params.conversation_id,
+        )
 
         conversation = await conversations_service.update_conversation(
             app=request.app,
-            project_id=dummy_project_id,  # Support conversations don't use project_id
+            project_id=None,  # Support conversations don't use project_id
             conversation_id=path_params.conversation_id,
             updates=ConversationPatchDB(name=body_params.name),
         )
@@ -242,16 +257,23 @@ async def delete_conversation(request: web.Request):
     try:
         req_ctx = AuthenticatedRequestContext.model_validate(request)
         path_params = parse_request_path_parameters_as(_ConversationPathParams, request)
+        query_params = parse_request_query_parameters_as(
+            _GetConversationsQueryParams, request
+        )
+        assert query_params.type == ConversationType.SUPPORT  # nosec
 
-        # For support conversations, we need a dummy project_id since the service requires it
-        from uuid import uuid4
-        dummy_project_id = uuid4()  # This won't be used for support conversations
+        await get_support_conversation_for_user(
+            app=request.app,
+            user_id=req_ctx.user_id,
+            product_name=req_ctx.product_name,
+            conversation_id=path_params.conversation_id,
+        )
 
         await conversations_service.delete_conversation(
             app=request.app,
             product_name=req_ctx.product_name,
             user_id=req_ctx.user_id,
-            project_id=dummy_project_id,  # Support conversations don't use project_id
+            project_id=None,  # Support conversations don't use project_id
             conversation_id=path_params.conversation_id,
         )
 
@@ -281,6 +303,7 @@ async def create_conversation_message(request: web.Request):
 
         # For support conversations, we need a dummy project_id since the service requires it
         from uuid import uuid4
+
         dummy_project_id = uuid4()  # This won't be used for support conversations
 
         message = await conversations_service.create_message(
@@ -297,7 +320,9 @@ async def create_conversation_message(request: web.Request):
 
     except Exception as exc:
         _logger.exception("Failed to create conversation message")
-        raise web.HTTPInternalServerError(reason="Failed to create conversation message") from exc
+        raise web.HTTPInternalServerError(
+            reason="Failed to create conversation message"
+        ) from exc
 
 
 @routes.get(
@@ -339,7 +364,9 @@ async def list_conversation_messages(request: web.Request):
 
     except Exception as exc:
         _logger.exception("Failed to list conversation messages")
-        raise web.HTTPInternalServerError(reason="Failed to list conversation messages") from exc
+        raise web.HTTPInternalServerError(
+            reason="Failed to list conversation messages"
+        ) from exc
 
 
 @routes.get(
@@ -350,7 +377,9 @@ async def list_conversation_messages(request: web.Request):
 async def get_conversation_message(request: web.Request):
     """Get a specific message in a conversation"""
     try:
-        path_params = parse_request_path_parameters_as(_ConversationMessagePathParams, request)
+        path_params = parse_request_path_parameters_as(
+            _ConversationMessagePathParams, request
+        )
 
         message = await conversations_service.get_message(
             app=request.app,
@@ -374,16 +403,14 @@ async def get_conversation_message(request: web.Request):
 async def update_conversation_message(request: web.Request):
     """Update a message in a conversation"""
     try:
-        path_params = parse_request_path_parameters_as(_ConversationMessagePathParams, request)
+        path_params = parse_request_path_parameters_as(
+            _ConversationMessagePathParams, request
+        )
         body_params = await parse_request_body_as(ConversationMessagePatch, request)
 
-        # For support conversations, we need a dummy project_id since the service requires it
-        from uuid import uuid4
-        dummy_project_id = uuid4()  # This won't be used for support conversations
-
         message = await conversations_service.update_message(
             app=request.app,
-            project_id=dummy_project_id,  # Support conversations don't use project_id
+            project_id=None,  # Support conversations don't use project_id
             conversation_id=path_params.conversation_id,
             message_id=path_params.message_id,
             updates=ConversationMessagePatchDB(content=body_params.content),
@@ -406,16 +433,14 @@ async def delete_conversation_message(request: web.Request):
     """Delete a message in a conversation"""
     try:
         req_ctx = AuthenticatedRequestContext.model_validate(request)
-        path_params = parse_request_path_parameters_as(_ConversationMessagePathParams, request)
-
-        # For support conversations, we need a dummy project_id since the service requires it
-        from uuid import uuid4
-        dummy_project_id = uuid4()  # This won't be used for support conversations
+        path_params = parse_request_path_parameters_as(
+            _ConversationMessagePathParams, request
+        )
 
         await conversations_service.delete_message(
             app=request.app,
             user_id=req_ctx.user_id,
-            project_id=dummy_project_id,  # Support conversations don't use project_id
+            project_id=None,  # Support conversations don't use project_id
             conversation_id=path_params.conversation_id,
             message_id=path_params.message_id,
         )

services/web/server/src/simcore_service_webserver/conversations/_conversation_message_service.py

@@ -73,7 +73,7 @@ async def get_message(
 async def update_message(
     app: web.Application,
     *,
-    project_id: ProjectID,
+    project_id: ProjectID | None,
     conversation_id: ConversationID,
     message_id: ConversationMessageID,
     # Update attributes
@@ -86,12 +86,13 @@ async def update_message(
         updates=updates,
     )
 
-    await notify_conversation_message_updated(
-        app,
-        recipients=await _get_recipients(app, project_id),
-        project_id=project_id,
-        conversation_message=updated_message,
-    )
+    if project_id:
+        await notify_conversation_message_updated(
+            app,
+            recipients=await _get_recipients(app, project_id),
+            project_id=project_id,
+            conversation_message=updated_message,
+        )
 
     return updated_message
 
@@ -100,7 +101,7 @@ async def delete_message(
     app: web.Application,
     *,
     user_id: UserID,
-    project_id: ProjectID,
+    project_id: ProjectID | None,
     conversation_id: ConversationID,
     message_id: ConversationMessageID,
 ) -> None:
@@ -112,14 +113,15 @@ async def delete_message(
 
     _user_group_id = await users_service.get_user_primary_group_id(app, user_id=user_id)
 
-    await notify_conversation_message_deleted(
-        app,
-        recipients=await _get_recipients(app, project_id),
-        user_group_id=_user_group_id,
-        project_id=project_id,
-        conversation_id=conversation_id,
-        message_id=message_id,
-    )
+    if project_id:
+        await notify_conversation_message_deleted(
+            app,
+            recipients=await _get_recipients(app, project_id),
+            user_group_id=_user_group_id,
+            project_id=project_id,
+            conversation_id=conversation_id,
+            message_id=message_id,
+        )
 
 
 async def list_messages_for_conversation(

services/web/server/src/simcore_service_webserver/conversations/_conversation_service.py

@@ -53,9 +53,6 @@ async def create_conversation(
     type_: ConversationType,
     extra_context: dict[str, Any],
 ) -> ConversationGetDB:
-    if project_uuid is None:
-        raise NotImplementedError
-
     _user_group_id = await users_service.get_user_primary_group_id(app, user_id=user_id)
 
     created_conversation = await _conversation_repository.create(
@@ -68,12 +65,13 @@ async def create_conversation(
         extra_context=extra_context,
     )
 
-    await notify_conversation_created(
-        app,
-        recipients=await _get_recipients(app, project_uuid),
-        project_id=project_uuid,
-        conversation=created_conversation,
-    )
+    if project_uuid:
+        await notify_conversation_created(
+            app,
+            recipients=await _get_recipients(app, project_uuid),
+            project_id=project_uuid,
+            conversation=created_conversation,
+        )
 
     return created_conversation
 
@@ -110,7 +108,7 @@ async def get_conversation_for_user(
 async def update_conversation(
     app: web.Application,
     *,
-    project_id: ProjectID,
+    project_id: ProjectID | None,
     conversation_id: ConversationID,
     # Update attributes
     updates: ConversationPatchDB,
@@ -121,12 +119,13 @@ async def update_conversation(
         updates=updates,
     )
 
-    await notify_conversation_updated(
-        app,
-        recipients=await _get_recipients(app, project_id),
-        project_id=project_id,
-        conversation=updated_conversation,
-    )
+    if project_id:
+        await notify_conversation_updated(
+            app,
+            recipients=await _get_recipients(app, project_id),
+            project_id=project_id,
+            conversation=updated_conversation,
+        )
 
     return updated_conversation
 
@@ -136,7 +135,7 @@ async def delete_conversation(
     *,
     product_name: ProductName,
     user_id: UserID,
-    project_id: ProjectID,
+    project_id: ProjectID | None,
     conversation_id: ConversationID,
 ) -> None:
     await _conversation_repository.delete(
@@ -146,14 +145,15 @@ async def delete_conversation(
 
     _user_group_id = await users_service.get_user_primary_group_id(app, user_id=user_id)
 
-    await notify_conversation_deleted(
-        app,
-        recipients=await _get_recipients(app, project_id),
-        product_name=product_name,
-        user_group_id=_user_group_id,
-        project_id=project_id,
-        conversation_id=conversation_id,
-    )
+    if project_id:
+        await notify_conversation_deleted(
+            app,
+            recipients=await _get_recipients(app, project_id),
+            product_name=product_name,
+            user_group_id=_user_group_id,
+            project_id=project_id,
+            conversation_id=conversation_id,
+        )
 
 
 async def list_project_conversations(
@@ -180,7 +180,7 @@ async def get_support_conversation_for_user(
     product_name: ProductName,
     conversation_id: ConversationID,
 ):
-    # Check if user is part of support group (in that case list all support conversations)
+    # Check if user is part of support group (in that case he has access to all support conversations)
     product = products_service.get_product(app, product_name=product_name)
     _support_standard_group_id = product.support_standard_group_id
     if _support_standard_group_id is not None: