Skip to content

Commit 4059459

Browse files
committed
moved fixtures and helpers to pytest-simcore
1 parent 5b41fb8 commit 4059459

File tree

9 files changed

+18
-13
lines changed

9 files changed

+18
-13
lines changed

services/storage/tests/helpers/utils.py renamed to packages/pytest-simcore/src/pytest_simcore/helpers/storage_utils.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import logging
22
import os
3+
from pathlib import Path
4+
from typing import TypedDict
35

46
import sqlalchemy as sa
7+
from models_library.basic_types import SHA256Str
58
from models_library.projects import ProjectAtDB
69
from simcore_postgres_database.storage_models import projects
710
from sqlalchemy.ext.asyncio import AsyncEngine
@@ -26,3 +29,8 @@ async def get_updated_project(
2629
)
2730
row = result.one()
2831
return ProjectAtDB.model_validate(row)
32+
33+
34+
class FileIDDict(TypedDict):
35+
path: Path
36+
sha256_checksum: SHA256Str

services/storage/tests/fixtures/data_models.py renamed to packages/pytest-simcore/src/pytest_simcore/simcore_storage_data_models.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from contextlib import asynccontextmanager
88
from pathlib import Path
99
from random import choice, randint
10-
from typing import Any, TypedDict, cast
10+
from typing import Any, cast
1111

1212
import pytest
1313
import sqlalchemy as sa
@@ -17,14 +17,14 @@
1717
from models_library.projects_nodes_io import NodeID, SimcoreS3FileID, StorageFileID
1818
from models_library.users import UserID
1919
from pydantic import ByteSize, TypeAdapter
20-
from pytest_simcore.helpers.faker_factories import random_project, random_user
2120
from servicelib.utils import limited_gather
2221
from simcore_postgres_database.models.project_to_groups import project_to_groups
2322
from simcore_postgres_database.storage_models import projects, users
2423
from sqlalchemy.dialects.postgresql import insert as pg_insert
2524
from sqlalchemy.ext.asyncio import AsyncConnection, AsyncEngine
2625

27-
from ..helpers.utils import get_updated_project
26+
from .helpers.faker_factories import random_project, random_user
27+
from .helpers.storage_utils import FileIDDict, get_updated_project
2828

2929

3030
@asynccontextmanager
@@ -259,11 +259,6 @@ async def _creator(
259259
return _creator
260260

261261

262-
class FileIDDict(TypedDict):
263-
path: Path
264-
sha256_checksum: SHA256Str
265-
266-
267262
async def _upload_file_and_update_project(
268263
project_id: ProjectID,
269264
node_id: NodeID,

services/storage/tests/conftest.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@
4646
from pytest_simcore.helpers.logging_tools import log_context
4747
from pytest_simcore.helpers.monkeypatch_envs import delenvs_from_dict, setenvs_from_dict
4848
from pytest_simcore.helpers.s3 import upload_file_to_presigned_link
49+
from pytest_simcore.helpers.storage_utils import FileIDDict
50+
from pytest_simcore.helpers.storage_utils_file_meta_data import (
51+
assert_file_meta_data_in_db,
52+
)
4953
from pytest_simcore.helpers.typing_env import EnvVarsDict
5054
from servicelib.aiohttp import status
5155
from simcore_postgres_database.storage_models import file_meta_data, projects, users
@@ -63,8 +67,6 @@
6367
from tenacity.retry import retry_if_exception_type
6468
from tenacity.stop import stop_after_delay
6569
from tenacity.wait import wait_fixed
66-
from tests.fixtures.data_models import FileIDDict
67-
from tests.helpers.utils_file_meta_data import assert_file_meta_data_in_db
6870
from types_aiobotocore_s3 import S3Client
6971
from yarl import URL
7072

@@ -82,8 +84,8 @@
8284
"pytest_simcore.postgres_service",
8385
"pytest_simcore.pytest_global_environs",
8486
"pytest_simcore.repository_paths",
85-
"tests.fixtures.data_models",
86-
"tests.fixtures.datcore_adapter",
87+
"pytest_simcore.simcore_storage_data_models",
88+
"pytest_simcore.simcore_storage_datcore_adapter",
8789
]
8890

8991
CURRENT_DIR = Path(sys.argv[0] if __name__ == "__main__" else __file__).resolve().parent

services/storage/tests/fixtures/__init__.py

Whitespace-only changes.

services/storage/tests/helpers/__init__.py

Whitespace-only changes.

services/storage/tests/unit/test_handlers_paths.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
from models_library.users import UserID
1919
from pytest_simcore.helpers.fastapi import url_from_operation_id
2020
from pytest_simcore.helpers.httpx_assert_checks import assert_status
21+
from pytest_simcore.helpers.storage_utils import FileIDDict
2122
from servicelib.aiohttp import status
22-
from tests.fixtures.data_models import FileIDDict
2323

2424
pytest_simcore_core_services_selection = ["postgres"]
2525
pytest_simcore_ops_services_selection = ["adminer"]

0 commit comments

Comments
 (0)