reverted changes

Author: Andrei Neagu

packages/service-library/src/servicelib/long_running_tasks/task.py

@@ -206,12 +206,7 @@ async def setup(self) -> None:
         )
         await self._started_event_task_tasks_monitor.wait()
 
-    async def remove_local_running_tasks(self) -> None:
-        """
-        NOTE: background `_task_cancelled_tasks_removal` will be shutdown by this function
-        only invoke this externally before shutting down the process to ensure
-        proper cleanup of local tasks fron Redis (e.g. before closing a dynamic sidecar)
-        """
+    async def teardown(self) -> None:
         # stop cancelled_tasks_removal
         if self._task_cancelled_tasks_removal:
             await cancel_wait_task(self._task_cancelled_tasks_removal)
@@ -237,9 +232,6 @@ async def _remove_local_task(task_data: TaskData) -> None:
             limit=_PARALLEL_TASKS_CANCELLATION,
         )
 
-    async def teardown(self) -> None:
-        await self.remove_local_running_tasks()
-
         # stop stale_tasks_monitor
         if self._task_stale_tasks_monitor:
             await cancel_wait_task(

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/api_client/_public.py

@@ -503,11 +503,6 @@ async def free_reserved_disk_space(
     ) -> None:
         await self._thin_client.post_disk_reserved_free(dynamic_sidecar_endpoint)
 
-    async def cleanup_long_running_tasks(
-        self, dynamic_sidecar_endpoint: AnyHttpUrl
-    ) -> None:
-        await self._thin_client.delete_long_running_tasks(dynamic_sidecar_endpoint)
-
 
 def _get_proxy_configuration(
     entrypoint_container_name: str, service_port: PortInt

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/api_client/_thin.py

@@ -302,12 +302,3 @@ async def post_disk_reserved_free(
     ) -> Response:
         url = self._get_url(dynamic_sidecar_endpoint, "disk/reserved:free")
         return await self.client.post(url)
-
-    @retry_on_errors()
-    @expect_status(status.HTTP_204_NO_CONTENT)
-    async def delete_long_running_tasks(
-        self,
-        dynamic_sidecar_endpoint: AnyHttpUrl,
-    ) -> Response:
-        url = self._get_url(dynamic_sidecar_endpoint, "long-running-tasks")
-        return await self.client.delete(url)