add separate method for hecking read access of file

Author: bisgaard-itis

services/storage/src/simcore_service_storage/api/rpc/_data_export.py

@@ -10,9 +10,9 @@
 )
 from servicelib.rabbitmq import RPCRouter
 
-from ...dsm import get_dsm_provider
+from ...dsm import DatCoreDataManager, get_dsm_provider
 from ...modules.datcore_adapter.datcore_adapter import DatcoreAdapterError
-from ...simcore_s3_dsm import FileAccessRightError
+from ...simcore_s3_dsm import FileAccessRightError, SimcoreS3DataManager
 
 router = RPCRouter()
 
@@ -33,7 +33,11 @@ async def start_data_export(
 
     try:
         for _id in data_export_start.file_and_folder_ids:
-            _ = await dsm.get_file(user_id=data_export_start.user_id, file_id=_id)
+            if isinstance(dsm, DatCoreDataManager):
+                _ = await dsm.get_file(user_id=data_export_start.user_id, file_id=_id)
+            elif isinstance(dsm, SimcoreS3DataManager):
+                await dsm.can_read_file(user_id=data_export_start.user_id, file_id=_id)
+
     except (FileAccessRightError, DatcoreAdapterError) as err:
         raise AccessRightError(
             user_id=data_export_start.user_id,

services/storage/src/simcore_service_storage/simcore_s3_dsm.py

@@ -355,6 +355,12 @@ async def get_file(self, user_id: UserID, file_id: StorageFileID) -> FileMetaDat
         fmd = await self._update_database_from_storage(fmd)
         return convert_db_to_model(fmd)
 
+    async def can_read_file(self, user_id: UserID, file_id: StorageFileID):
+        async with self.engine.connect() as conn:
+            can = await get_file_access_rights(conn, int(user_id), file_id)
+            if not can.read:
+                raise FileAccessRightError(access_right="read", file_id=file_id)
+
     async def create_file_upload_links(
         self,
         user_id: UserID,