remove servicelib from dask-task-models

Author: sanderegg

packages/dask-task-models-library/src/dask_task_models_library/plugins/task_life_cycle_scheduler_plugin.py

@@ -5,7 +5,6 @@
 from dask.typing import Key
 from distributed import Scheduler, SchedulerPlugin
 from distributed.scheduler import TaskStateState
-from servicelib.logging_utils import log_context
 
 from ..models import TASK_LIFE_CYCLE_EVENT, TaskLifeCycleState
 
@@ -14,20 +13,12 @@
 
 class TaskLifecycleSchedulerPlugin(SchedulerPlugin):
     def __init__(self) -> None:
-        with log_context(
-            _logger,
-            logging.INFO,
-            "TaskLifecycleSchedulerPlugin init",
-        ):
-            self.scheduler = None
+        self.scheduler = None
+        _logger.info("initialized TaskLifecycleSchedulerPlugin")
 
     async def start(self, scheduler: Scheduler) -> None:
-        with log_context(
-            _logger,
-            logging.INFO,
-            "TaskLifecycleSchedulerPlugin start",
-        ):
-            self.scheduler = scheduler  # type: ignore[assignment]
+        self.scheduler = scheduler  # type: ignore[assignment]
+        _logger.info("started TaskLifecycleSchedulerPlugin")
 
     def transition(
         self,
@@ -38,19 +29,22 @@ def transition(
         stimulus_id: str,
         **kwargs: Any,
     ):
-        with log_context(
-            _logger,
-            logging.INFO,
-            f"Task {key!r} transition from {start} to {finish} due to {stimulus_id=}",
-        ):
-            assert self.scheduler  # nosec
-
-            self.scheduler.log_event(
-                TASK_LIFE_CYCLE_EVENT.format(key=key),
-                TaskLifeCycleState.from_scheduler_task_state(
-                    key, kwargs.get("worker"), finish
-                ).model_dump(mode="json"),
-            )
+        _logger.debug(
+            "Task %s transition from %s to %s due to %s",
+            key,
+            start,
+            finish,
+            stimulus_id,
+        )
+
+        assert self.scheduler  # nosec
+
+        self.scheduler.log_event(
+            TASK_LIFE_CYCLE_EVENT.format(key=key),
+            TaskLifeCycleState.from_scheduler_task_state(
+                key, kwargs.get("worker"), finish
+            ).model_dump(mode="json"),
+        )
 
 
 @click.command()

packages/dask-task-models-library/src/dask_task_models_library/plugins/task_life_cycle_worker_plugin.py

@@ -7,7 +7,6 @@
 from distributed import WorkerPlugin
 from distributed.worker import Worker
 from distributed.worker_state_machine import TaskStateState
-from servicelib.logging_utils import log_context
 
 from ..models import TASK_LIFE_CYCLE_EVENT, TaskLifeCycleState
 
@@ -16,21 +15,13 @@
 
 class TaskLifecycleWorkerPlugin(WorkerPlugin):
     def __init__(self) -> None:
-        with log_context(
-            _logger,
-            logging.INFO,
-            "TaskLifecycleWorkerPlugin init",
-        ):
-            self._worker = None
+        self._worker = None
+        _logger.info("TaskLifecycleWorkerPlugin initialized")
 
     def setup(self, worker: Worker) -> Awaitable[None]:
         async def _() -> None:
-            with log_context(
-                _logger,
-                logging.INFO,
-                "TaskLifecycleWorkerPlugin start",
-            ):
-                self._worker = worker  # type: ignore[assignment]
+            self._worker = worker  # type: ignore[assignment]
+            _logger.info("TaskLifecycleWorkerPlugin setup completed")
 
         return _()
 
@@ -41,18 +32,14 @@ def transition(
         finish: TaskStateState,
         **kwargs: Any,
     ):
-        with log_context(
-            _logger,
-            logging.INFO,
-            f"Task {key!r} transition from {start} to {finish}",
-        ):
-            assert self._worker  # nosec
-            self._worker.log_event(
-                TASK_LIFE_CYCLE_EVENT.format(key=key),
-                TaskLifeCycleState.from_worker_task_state(
-                    key, kwargs.get("worker"), finish
-                ).model_dump(mode="json"),
-            )
+        _logger.info("Task '%s' transition from %s to %s", key, start, finish)
+        assert self._worker  # nosec
+        self._worker.log_event(
+            TASK_LIFE_CYCLE_EVENT.format(key=key),
+            TaskLifeCycleState.from_worker_task_state(
+                key, kwargs.get("worker"), finish
+            ).model_dump(mode="json"),
+        )
 
 
 @click.command()