cleanup

Author: pcrespov

services/web/server/src/simcore_service_webserver/garbage_collector/_tasks_users.py

@@ -4,7 +4,7 @@
 """
 
 import logging
-from collections.abc import AsyncIterator, Callable
+from collections.abc import AsyncIterator
 from datetime import timedelta
 
 from aiohttp import web
@@ -20,8 +20,6 @@
 
 _logger = logging.getLogger(__name__)
 
-CleanupContextFunc = Callable[[web.Application], AsyncIterator[None]]
-
 
 async def notify_user_logout_all_sessions(
     app: web.Application, user_id: UserID

services/web/server/src/simcore_service_webserver/garbage_collector/_tasks_utils.py

@@ -23,7 +23,7 @@ async def setup_periodic_task(
         periodic_task_coro: The periodic task coroutine function (already decorated with @exclusive_periodic)
     """
     # setup
-    task_name = periodic_task_coro.__name__
+    task_name = f"{periodic_task_coro.__module__}.{periodic_task_coro.__name__}"
 
     task = asyncio.create_task(
         periodic_task_coro(),
@@ -32,6 +32,10 @@ async def setup_periodic_task(
 
     # prevents premature garbage collection of the task
     app_task_key = f"tasks.{task_name}"
+    if app_task_key in app:
+        msg = f"Task {task_name} is already registered in the app state"
+        raise ValueError(msg)
+
     app[app_task_key] = task
 
     yield