Skip to content

Commit 455f26e

Browse files
committed
minor
1 parent 66b4b32 commit 455f26e

File tree

1 file changed

+11
-5
lines changed
  • services/static-webserver/client/source/class/osparc/conversation

1 file changed

+11
-5
lines changed

services/static-webserver/client/source/class/osparc/conversation/Conversation.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -263,14 +263,20 @@ qx.Class.define("osparc.conversation.Conversation", {
263263
},
264264

265265
deleteMessage: function(message) {
266+
// remove it from the messages array
266267
const messageIndex = this.__messages.findIndex(msg => msg["messageId"] === message["messageId"]);
267-
if (messageIndex !== -1) {
268-
this.__messages.splice(messageIndex, 1);
269-
270-
this.__updateMessagesNumber();
268+
if (messageIndex === -1) {
269+
return;
270+
}
271+
this.__messages.splice(messageIndex, 1);
271272

272-
console.log(this.__messagesList.getChildren());
273+
// remove the ui element
274+
const index = this.__messagesList.getChildren().findIndex(control => ("getMessage" in control && control.getMessage()["messageId"] === message["messageId"]));
275+
if (index > -1) {
276+
this.__messagesList.getChildren().removeAt(index);
273277
}
278+
279+
this.__updateMessagesNumber();
274280
},
275281

276282
updateMessage: function(message) {

0 commit comments

Comments
 (0)