Skip to content

Commit 45cb2cf

Browse files
author
Andrei Neagu
committed
refactored tests
1 parent e3cb2e5 commit 45cb2cf

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

services/dynamic-scheduler/tests/unit/services/postgres/test__project_networks.py

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,9 @@ async def project_in_db(
105105
yield row
106106

107107

108-
async def test_no_project_networks_for_project(
109-
engine: AsyncEngine, project_in_db: dict[str, Any], project_id: ProjectID
110-
):
111-
repo = ProjectNetworksRepo(engine)
112-
113-
with pytest.raises(ProjectNetworkNotFoundError):
114-
await repo.get_projects_networks(project_id=project_id)
108+
@pytest.fixture()
109+
def project_networks_repo(engine: AsyncEngine) -> ProjectNetworksRepo:
110+
return ProjectNetworksRepo(engine)
115111

116112

117113
@pytest.fixture
@@ -121,20 +117,30 @@ def networks_with_aliases() -> NetworksWithAliases:
121117
)
122118

123119

120+
async def test_no_project_networks_for_project(
121+
project_networks_repo: ProjectNetworksRepo,
122+
project_in_db: dict[str, Any],
123+
project_id: ProjectID,
124+
):
125+
with pytest.raises(ProjectNetworkNotFoundError):
126+
await project_networks_repo.get_projects_networks(project_id=project_id)
127+
128+
124129
async def test_upsert_projects_networks(
125-
engine: AsyncEngine,
130+
project_networks_repo: ProjectNetworksRepo,
126131
project_in_db: dict[str, Any],
127132
project_id: ProjectID,
128133
networks_with_aliases: NetworksWithAliases,
129134
):
130-
repo = ProjectNetworksRepo(engine)
131135

132136
# allows ot test the upsert capabilities
133137
for _ in range(2):
134-
await repo.upsert_projects_networks(
138+
await project_networks_repo.upsert_projects_networks(
135139
project_id=project_id, networks_with_aliases=networks_with_aliases
136140
)
137141

138-
project_networks = await repo.get_projects_networks(project_id=project_id)
142+
project_networks = await project_networks_repo.get_projects_networks(
143+
project_id=project_id
144+
)
139145
assert project_networks.project_uuid == project_id
140146
assert project_networks.networks_with_aliases == networks_with_aliases

0 commit comments

Comments
 (0)