removed unused

Author: Andrei Neagu

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_core.py

@@ -123,11 +123,7 @@ async def _start_and_mark_as_started(
         expected_steps_count=expected_steps_count,
     )
     await step_proxy.set_multiple(
-        {
-            "deferred_created": True,
-            "status": StepStatus.SCHEDULED,
-            "success_processed": False,  # TODO: remove this one, not used more than likely
-        }
+        {"deferred_created": True, "status": StepStatus.SCHEDULED}
     )
 
 

services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/generic_scheduler/_store.py

@@ -283,7 +283,6 @@ class _StepDict(TypedDict):
     deferred_task_uid: NotRequired[TaskUID]
     error_traceback: NotRequired[str]
     requires_manual_intervention: NotRequired[bool]
-    success_processed: NotRequired[bool]
 
 
 DeleteStepKeys = Literal[
@@ -292,7 +291,6 @@ class _StepDict(TypedDict):
     "deferred_task_uid",
     "error_traceback",
     "requires_manual_intervention",
-    "success_processed",
 ]
 
 
@@ -333,8 +331,6 @@ async def get(self, key: Literal["error_traceback"]) -> str: ...
     async def get(self, key: Literal["requires_manual_intervention"]) -> bool: ...
     @overload
     async def get(self, key: Literal["deferred_created"]) -> bool: ...
-    @overload
-    async def get(self, key: Literal["success_processed"]) -> bool: ...
     async def get(self, key: str) -> Any:
         """raises KeyNotFoundInHashError if the key is not present in the hash"""
         hash_key = self._get_hash_key()
@@ -357,8 +353,6 @@ async def set(
     ) -> None: ...
     @overload
     async def set(self, key: Literal["deferred_created"], *, value: bool) -> None: ...
-    @overload
-    async def set(self, key: Literal["success_processed"], *, value: bool) -> None: ...
     async def set(self, key: str, value: Any) -> None:
         await self._store.set(self._get_hash_key(), key, value)
 

services/dynamic-scheduler/tests/unit/services/generic_scheduler/test__store.py

@@ -205,7 +205,6 @@ async def test_step_store_proxy_workflow(
             "error_traceback": "mock_traceback",
             "requires_manual_intervention": True,
             "deferred_created": True,
-            "success_processed": False,
         }
     )
     await _assert_keys(store, {hash_key})
@@ -218,7 +217,6 @@ async def test_step_store_proxy_workflow(
             "error_traceback",
             "requires_manual_intervention",
             "deferred_created",
-            "success_processed",
         },
     )
 
@@ -232,7 +230,6 @@ async def test_step_store_proxy_workflow(
             "error_traceback",
             "requires_manual_intervention",
             "deferred_created",
-            "success_processed",
         )
     await _assert_keys(store, set())
     await _assert_keys_in_hash(store, hash_key, set())
@@ -335,7 +332,6 @@ async def test_operation_removal_proxy(store: Store, schedule_id: ScheduleId):
             "deferred_task_uid": TaskUID("mytask"),
             "requires_manual_intervention": True,
             "error_traceback": "mock_traceback",
-            "success_processed": False,
         }
     )