done

Author: sanderegg

.github/copilot-instructions.md

@@ -21,7 +21,7 @@ This document provides guidelines and best practices for using GitHub Copilot in
 - ensure we use `sqlalchemy` >2 compatible code.
 - ensure we use `pydantic` >2 compatible code.
 - ensure we use `fastapi` >0.100 compatible code
-
+- use f-string formatting
 
 ## Node.js-Specific Instructions
 

packages/pytest-simcore/src/pytest_simcore/helpers/monkeypatch_envs.py

@@ -30,6 +30,9 @@ def setenvs_from_dict(
         if isinstance(value, bool):
             v = "true" if value else "false"
 
+        if isinstance(value, int | float):
+            v = f"{value}"
+
         assert isinstance(v, str), (
             "caller MUST explicitly stringify values since some cannot be done automatically"
             f"e.g. json-like values. Check {key=},{value=}"

packages/service-library/tests/fastapi/test_rabbitmq_lifespan.py

@@ -39,7 +39,7 @@ def mock_rabbitmq_connection(mocker: MockerFixture) -> MockType:
 def mock_rabbitmq_rpc_client_class(mocker: MockerFixture) -> MockType:
     mock_rpc_client_instance = mocker.AsyncMock()
     mocker.patch.object(
-        servicelib.rabbitmq._client_rpc.RabbitMQRPCClient,
+        servicelib.rabbitmq._client_rpc.RabbitMQRPCClient,  # noqa: SLF001
         "create",
         return_value=mock_rpc_client_instance,
     )
@@ -87,7 +87,6 @@ async def my_app_rpc_server(app: FastAPI, state: State) -> AsyncIterator[State]:
 
     # setup rpc-client using rabbitmq_rpc_client_context
     async def my_app_rpc_client(app: FastAPI, state: State) -> AsyncIterator[State]:
-
         assert "RABBIT_CONNECTIVITY_LIFESPAN_NAME" in state
 
         async with rabbitmq_rpc_client_context(
@@ -122,7 +121,6 @@ async def test_lifespan_rabbitmq_in_an_app(
         startup_timeout=None if is_pdb_enabled else 10,
         shutdown_timeout=None if is_pdb_enabled else 10,
     ):
-
         # Verify that RabbitMQ responsiveness was checked
         mock_rabbitmq_connection.assert_called_once_with(
             app.state.settings.RABBITMQ.dsn