🗃️ adding minor projects comments table changes + forgotten migration (#4395)

Author: matusdrobuliak66

packages/postgres-database/src/simcore_postgres_database/migration/versions/52cf00912ad9_project_comments_minor_improvements.py

@@ -0,0 +1,42 @@
+"""project comments minor improvements
+
+Revision ID: 52cf00912ad9
+Revises: af5de00bf4cf
+Create Date: 2023-06-21 13:05:19.531115+00:00
+
+"""
+import sqlalchemy as sa
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = "52cf00912ad9"
+down_revision = "af5de00bf4cf"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "projects_comments", "user_id", existing_type=sa.BIGINT(), nullable=True
+    )
+    op.create_foreign_key(
+        "fk_projects_comments_user_id",
+        "projects_comments",
+        "users",
+        ["user_id"],
+        ["id"],
+        ondelete="SET NULL",
+    )
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_constraint(
+        "fk_projects_comments_user_id", "projects_comments", type_="foreignkey"
+    )
+    op.alter_column(
+        "projects_comments", "user_id", existing_type=sa.BIGINT(), nullable=False
+    )
+    # ### end Alembic commands ###

packages/postgres-database/src/simcore_postgres_database/models/projects_comments.py

@@ -3,6 +3,7 @@
 from ._common import column_created_datetime, column_modified_datetime
 from .base import metadata
 from .projects import projects
+from .users import users
 
 projects_comments = sa.Table(
     "projects_comments",
@@ -25,12 +26,20 @@
             onupdate="CASCADE",
         ),
         index=True,
+        nullable=False,
         doc="project reference for this table",
     ),
+    # NOTE: if the user gets deleted, it sets to null which should be interpreted as "unknown" user
     sa.Column(
         "user_id",
         sa.BigInteger,
+        sa.ForeignKey(
+            users.c.id,
+            name="fk_projects_comments_user_id",
+            ondelete="SET NULL",
+        ),
         doc="user who created the comment",
+        nullable=True,
     ),
     sa.Column(
         "contents",