cleanup

Author: odeimaiz

services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js

@@ -95,7 +95,7 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
       return isLogged;
     },
 
-    startStudyById: function(studyId, openCB, cancelCB, isStudyCreation = false, skipStudyOptions = false) {
+    startStudyById: function(studyId, openCB, cancelCB, isStudyCreation = false) {
       if (!osparc.dashboard.ResourceBrowserBase.checkLoggedIn()) {
         return;
       }
@@ -117,12 +117,9 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
         osparc.data.Resources.fetch("studies", "getWallet", params)
           .then(wallet => {
             if (
-              !skipStudyOptions &&
-              (
-                isStudyCreation ||
-                wallet === null ||
-                osparc.desktop.credits.Utils.getWallet(wallet["walletId"]) === null
-              )
+              isStudyCreation ||
+              wallet === null ||
+              osparc.desktop.credits.Utils.getWallet(wallet["walletId"]) === null
             ) {
               // pop up study options if the study was just created or if it has no wallet assigned or user has no access to it
               const resourceSelector = new osparc.study.StudyOptions(studyId);
@@ -463,11 +460,11 @@ qx.Class.define("osparc.dashboard.ResourceBrowserBase", {
       throw new Error("Abstract method called!");
     },
 
-    _startStudyById: function(studyId, openCB, cancelCB, isStudyCreation = false, skipStudyOptions = false) {
+    _startStudyById: function(studyId, openCB, cancelCB, isStudyCreation = false) {
       if (isStudyCreation) {
         this.fireDataEvent("changeTab", "studiesTab");
       }
-      this.self().startStudyById(studyId, openCB, cancelCB, isStudyCreation, skipStudyOptions);
+      this.self().startStudyById(studyId, openCB, cancelCB, isStudyCreation);
     },
 
     _createStudyFromTemplate: function() {

services/static-webserver/client/source/class/osparc/dashboard/TemplateBrowser.js

@@ -151,8 +151,7 @@ qx.Class.define("osparc.dashboard.TemplateBrowser", {
             osparc.data.Resources.fetch("studies", "delete", params);
           };
           const isStudyCreation = true;
-          const skipStudyOptions = true;
-          this._startStudyById(studyId, openCB, cancelCB, isStudyCreation, skipStudyOptions);
+          this._startStudyById(studyId, openCB, cancelCB, isStudyCreation);
         })
         .catch(err => {
           this._hideLoadingPage();

services/static-webserver/client/source/class/osparc/study/StudyOptions.js

@@ -228,15 +228,13 @@ qx.Class.define("osparc.study.StudyOptions", {
     __buildTopSummaryLayout: function() {
       const store = osparc.store.Store.getInstance();
 
-      this._createChildControlImpl("title-label");
       const titleField = this.getChildControl("title-field");
       titleField.addListener("appear", () => {
         titleField.focus();
         titleField.activate();
       });
 
       // Wallet Selector
-      this._createChildControlImpl("wallet-selector-label");
       const walletSelector = this.getChildControl("wallet-selector");
 
       const wallets = store.getWallets();