renamed

Author: Andrei Neagu

packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/dynamic_sidecar/volumes.py

@@ -13,7 +13,7 @@
 
 
 @log_decorator(_logger, level=logging.DEBUG)
-async def save_volume_state(
+async def update_volume_status(
     rabbitmq_rpc_client: RabbitMQRPCClient,
     *,
     node_id: NodeID,
@@ -23,7 +23,7 @@ async def save_volume_state(
     rpc_namespace = get_rpc_namespace(node_id)
     result = await rabbitmq_rpc_client.request(
         rpc_namespace,
-        TypeAdapter(RPCMethodName).validate_python("save_volume_state"),
+        TypeAdapter(RPCMethodName).validate_python("update_volume_status"),
         status=status,
         category=category,
     )

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/volumes.py

@@ -26,4 +26,6 @@ async def put_volume_state(
     app: Annotated[FastAPI, Depends(get_application)],
     volume_category: Annotated[VolumeCategory, PathParam(..., alias="id")],
 ) -> None:
-    await volumes.save_volume_state(app, status=item.status, category=volume_category)
+    await volumes.update_volume_status(
+        app, status=item.status, category=volume_category
+    )

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rpc/_volumes.py

@@ -10,7 +10,7 @@
 
 @router.expose()
 @validate_call(config={"arbitrary_types_allowed": True})
-async def save_volume_state(
+async def update_volume_status(
     app: FastAPI, *, status: VolumeStatus, category: VolumeCategory
 ) -> None:
-    await volumes.save_volume_state(app, status=status, category=category)
+    await volumes.update_volume_status(app, status=status, category=category)

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/services/volumes.py

@@ -4,7 +4,7 @@
 from ..models.shared_store import get_shared_store
 
 
-async def save_volume_state(
+async def update_volume_status(
     app: FastAPI, *, status: VolumeStatus, category: VolumeCategory
 ) -> None:
     shared_store = get_shared_store(app)

services/dynamic-sidecar/tests/unit/api/rpc/test__volumes.py

@@ -42,7 +42,7 @@ async def test_volumes_state_saved_ok(
         status=initial_expected_status
     )
 
-    await volumes.save_volume_state(
+    await volumes.update_volume_status(
         rpc_client,
         node_id=settings.DY_SIDECAR_NODE_ID,
         status=VolumeStatus.CONTENT_WAS_SAVED,
@@ -66,7 +66,7 @@ async def test_volumes_state_saved_error(
     settings: ApplicationSettings = app.state.settings
 
     with pytest.raises(RPCServerError, match="ValidationError"):
-        await volumes.save_volume_state(
+        await volumes.update_volume_status(
             rpc_client,
             node_id=settings.DY_SIDECAR_NODE_ID,
             status=VolumeStatus.CONTENT_WAS_SAVED,