Skip to content

Commit 4aaa20d

Browse files
committed
cleanup
1 parent 694a0d7 commit 4aaa20d

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

services/web/server/src/simcore_service_webserver/users/_users_repository.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -157,15 +157,16 @@ async def get_user_or_raise(
157157
assert return_column_names is not None # nosec
158158
assert set(return_column_names).issubset(users.columns.keys()) # nosec
159159

160+
query = sa.select(*(users.columns[name] for name in return_column_names)).where(
161+
users.c.id == user_id
162+
)
163+
160164
async with pass_or_acquire_connection(engine, connection) as conn:
161-
result = await conn.execute(
162-
sa.select(*(users.columns[name] for name in return_column_names)).where(
163-
users.c.id == user_id
164-
)
165-
)
165+
result = await conn.execute(query)
166166
row = result.first()
167167
if row is None:
168168
raise UserNotFoundError(uid=user_id)
169+
169170
user: dict[str, Any] = row._asdict()
170171
return user
171172

@@ -433,7 +434,7 @@ async def get_user_billing_details(
433434
async with pass_or_acquire_connection(engine, connection) as conn:
434435
query = UsersRepo.get_billing_details_query(user_id=user_id)
435436
result = await conn.execute(query)
436-
row = result.fetchone()
437+
row = result.first()
437438
if not row:
438439
raise BillingDetailsNotFoundError(user_id=user_id)
439440
return UserBillingDetails.model_validate(row)
@@ -448,7 +449,7 @@ async def delete_user_by_id(
448449
.where(users.c.id == user_id)
449450
.returning(users.c.id) # Return the ID of the deleted row otherwise None
450451
)
451-
deleted_user = result.fetchone()
452+
deleted_user = result.first()
452453

453454
# If no row was deleted, the user did not exist
454455
return bool(deleted_user)

0 commit comments

Comments
 (0)