fix findings

Author: giancarloromeo

packages/celery-library/tests/conftest.py

@@ -92,7 +92,7 @@ def celery_config() -> dict[str, Any]:
 
 
 @pytest.fixture
-async def with_storage_celery_worker(
+async def with_celery_worker(
     celery_app: Celery,
     app_server: BaseAppServer,
     celery_settings: CelerySettings,
@@ -121,7 +121,7 @@ def _on_worker_init_wrapper(sender: WorkController, **_kwargs):
 async def celery_task_manager(
     celery_app: Celery,
     celery_settings: CelerySettings,
-    with_storage_celery_worker: TestWorkController,
+    with_celery_worker: TestWorkController,
 ) -> CeleryTaskManager:
     return await create_task_manager(
         celery_app,

packages/celery-library/tests/unit/test_tasks.py

@@ -55,7 +55,7 @@ def sleep_for(seconds: float) -> None:
 
 
 def fake_file_processor(task: Task, task_id: TaskID, files: list[str]) -> str:
-    _ = task_id
+    assert task_id
     assert task.name
     _logger.info("Calling _fake_file_processor")
     return asyncio.run_coroutine_threadsafe(
@@ -69,7 +69,7 @@ class MyError(OsparcErrorMixin, Exception):
 
 
 def failure_task(task: Task, task_id: TaskID) -> None:
-    _ = task_id
+    assert task_id
     assert task
     msg = "BOOM!"
     raise MyError(msg=msg)

services/storage/src/simcore_service_storage/api/rest/_files.py

@@ -292,7 +292,7 @@ async def complete_upload_file(
         user_id=async_job_name_data.user_id,
         location_id=location_id,
         file_id=file_id,
-        body=body.model_dump(),
+        body=body,
     )
 
     route = (
@@ -356,7 +356,7 @@ async def is_completed_upload_file(
         assert new_fmd.file_id == file_id  # nosec
         response = FileUploadCompleteFutureResponse(
             state=FileUploadCompleteState.OK,
-            e_tag=FileMetaData.model_validate(new_fmd).entity_tag,
+            e_tag=new_fmd.entity_tag,
         )
     else:
         # the task is still running

services/storage/src/simcore_service_storage/api/rpc/_simcore_s3.py

@@ -27,7 +27,7 @@ async def copy_folders_from_project(
         ),
         task_context=job_id_data.model_dump(),
         user_id=job_id_data.user_id,
-        body=body.model_dump(mode="json"),
+        body=body,
     )
 
     return AsyncJobGet(job_id=task_uuid, job_name=task_name)