Skip to content

Commit 4b7bc3d

Browse files
add Note
1 parent 521a27d commit 4b7bc3d

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

services/web/server/src/simcore_service_webserver/folders/_folders_rest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ async def replace_folder(request: web.Request):
205205
@login_required
206206
@permission_required("folder.delete")
207207
@handle_plugin_requests_exceptions
208-
async def delete_folder_group(request: web.Request):
208+
async def delete_folder(request: web.Request):
209209
req_ctx = FoldersRequestContext.model_validate(request)
210210
path_params = parse_request_path_parameters_as(FoldersPathParams, request)
211211

services/web/server/src/simcore_service_webserver/folders/_folders_service.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,9 @@ async def delete_folder_with_all_content(
349349

350350
# 1. Delete folder content
351351
# 1.1 Delete all child projects that I am an owner
352+
# NOTE: The reason for this is to be cautious and not delete projects by accident that
353+
# are not owned by the user (even if the user was granted delete permissions). As a consequence, after deleting the folder,
354+
# projects that the user does not own will appear in the root. (Maybe this can be changed as we now have a trash system).
352355
project_id_list: list[ProjectID] = (
353356
await _folders_repository.get_projects_recursively_only_if_user_is_owner(
354357
app,

0 commit comments

Comments
 (0)