Skip to content

Commit 4c5a0f3

Browse files
✨ [Frontend] Update to new collection runs (#8074)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 0d18a1b commit 4c5a0f3

File tree

13 files changed

+164
-121
lines changed

13 files changed

+164
-121
lines changed

services/static-webserver/client/source/class/osparc/data/Job.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,33 @@ qx.Class.define("osparc.data.Job", {
2222
this.base(arguments);
2323

2424
this.set({
25-
projectUuid: jobData["projectUuid"],
26-
projectName: jobData["rootProjectName"] || "",
25+
collectionRunId: jobData["collectionRunId"],
26+
projectIds: jobData["projectIds"],
27+
name: jobData["name"] || "",
2728
state: jobData["state"] || "UNKNOWN",
2829
submittedAt: jobData["submittedAt"] ? new Date(jobData["submittedAt"]) : null,
2930
startedAt: jobData["startedAt"] ? new Date(jobData["startedAt"]) : null,
3031
endedAt: jobData["endedAt"] ? new Date(jobData["endedAt"]) : null,
3132
info: jobData["info"] || null,
32-
customMetadata: jobData["projectCustomMetadata"] || null,
3333
});
3434

3535
this.__subJobs = [];
3636
},
3737

3838
properties: {
39-
projectUuid: {
39+
collectionRunId: {
4040
check: "String",
4141
nullable: false,
4242
init: null,
4343
},
4444

45-
projectName: {
45+
projectIds: {
46+
check: "Array",
47+
nullable: false,
48+
init: null,
49+
},
50+
51+
name: {
4652
check: "String",
4753
nullable: false,
4854
init: null,
@@ -77,12 +83,6 @@ qx.Class.define("osparc.data.Job", {
7783
nullable: true,
7884
init: null,
7985
},
80-
81-
customMetadata: {
82-
check: "Object",
83-
nullable: true,
84-
init: null,
85-
},
8686
},
8787

8888
statics: {
@@ -104,14 +104,14 @@ qx.Class.define("osparc.data.Job", {
104104
members: {
105105
__subJobs: null,
106106

107-
addSubJob: function(subJobData) {
107+
addSubJob: function(collectionRunId, subJobData) {
108108
const subJobFound = this.__subJobs.find(subJb => subJb.getNodeId() === subJobData["nodeId"]);
109109
if (subJobFound) {
110110
subJobFound.updateSubJob(subJobData);
111111
return subJobFound;
112112
}
113113

114-
const subJob = new osparc.data.SubJob(subJobData);
114+
const subJob = new osparc.data.SubJob(collectionRunId, subJobData);
115115
this.__subJobs.push(subJob);
116116
return subJob;
117117
},

services/static-webserver/client/source/class/osparc/data/Resources.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -368,11 +368,13 @@ qx.Class.define("osparc.data.Resources", {
368368
endpoints: {
369369
getPageLatest: {
370370
method: "GET",
371-
url: statics.API + "/computations/-/iterations/latest?offset={offset}&limit={limit}&order_by={orderBy}&filter_only_running={runningOnly}&filters={filters}"
371+
// uncomment this when the backend supports filtering by runningOnly #8055
372+
// url: statics.API + "/computation-collection-runs?offset={offset}&limit={limit}&order_by={orderBy}&filter_only_running={runningOnly}"
373+
url: statics.API + "/computation-collection-runs?offset={offset}&limit={limit}&order_by={orderBy}&filter_only_running=false"
372374
},
373375
getPageHistory: {
374376
method: "GET",
375-
url: statics.API + "/computations/{studyId}/iterations?offset={offset}&limit={limit}&order_by={orderBy}&include_children={includeChildren}"
377+
url: statics.API + "/computation-collection-runs?offset={offset}&limit={limit}&order_by={orderBy}&filter_by_root_project_id={projectId}"
376378
},
377379
}
378380
},
@@ -381,7 +383,7 @@ qx.Class.define("osparc.data.Resources", {
381383
endpoints: {
382384
getPageLatest: {
383385
method: "GET",
384-
url: statics.API + "/computations/{studyId}/iterations/latest/tasks?offset={offset}&limit={limit}&order_by={orderBy}&include_children={includeChildren}"
386+
url: statics.API + "/computation-collection-runs/{collectionRunId}/tasks?offset={offset}&limit={limit}&order_by={orderBy}"
385387
},
386388
}
387389
},

services/static-webserver/client/source/class/osparc/data/SubJob.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@
1818
qx.Class.define("osparc.data.SubJob", {
1919
extend: qx.core.Object,
2020

21-
construct: function(subJobData) {
21+
construct: function(collectionRunId, subJobData) {
2222
this.base(arguments);
2323

2424
this.set({
25+
collectionRunId,
2526
projectUuid: subJobData["projectUuid"],
2627
nodeId: subJobData["nodeId"],
2728
});
@@ -30,6 +31,12 @@ qx.Class.define("osparc.data.SubJob", {
3031
},
3132

3233
properties: {
34+
collectionRunId: {
35+
check: "String",
36+
nullable: false,
37+
init: null,
38+
},
39+
3340
projectUuid: {
3441
check: "String",
3542
nullable: false,
@@ -42,7 +49,7 @@ qx.Class.define("osparc.data.SubJob", {
4249
init: null,
4350
},
4451

45-
nodeName: {
52+
name: {
4653
check: "String",
4754
nullable: false,
4855
init: null,
@@ -94,7 +101,7 @@ qx.Class.define("osparc.data.SubJob", {
94101
members: {
95102
updateSubJob: function(subJobData) {
96103
this.set({
97-
nodeName: subJobData["nodeName"],
104+
name: subJobData["name"],
98105
state: subJobData["state"],
99106
progress: subJobData["progress"],
100107
startedAt: subJobData["startedAt"] ? new Date(subJobData["startedAt"]) : null,

services/static-webserver/client/source/class/osparc/jobs/ActivityCenterWindow.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ qx.Class.define("osparc.jobs.ActivityCenterWindow", {
5959

6060
runsBrowser.addListener("runSelected", e => {
6161
const data = e.getData();
62-
const project = data["rowData"];
63-
subRunsBrowser.setProject(project);
62+
const collectionRunData = data["rowData"];
63+
subRunsBrowser.setCollectionRun(collectionRunData);
6464
this.getChildControl("title").setValue(this.tr("Tasks"));
6565
stack.setSelection([subRunsBrowser]);
6666
});

services/static-webserver/client/source/class/osparc/jobs/ActivityOverview.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ qx.Class.define("osparc.jobs.ActivityOverview", {
5656

5757
this.__runsTable.addListener("runSelected", e => {
5858
const data = e.getData();
59-
const project = data["rowData"];
60-
const projectUuid = project["projectUuid"];
59+
const collectionRunData = data["rowData"];
60+
const collectionRunId = collectionRunData["collectionRunId"];
6161
// Hacky-hacky
6262
for (let i=0; i<this.__runsTable.getTableModel().getRowCount(); i++) {
6363
const rowData = this.__runsTable.getTableModel().getRowData(i);
64-
if (rowData["projectUuid"] === projectUuid && data["rowIdx"] > i) {
64+
if (rowData["collectionRunId"] === collectionRunId && data["rowIdx"] > i) {
6565
const msg = this.tr("Only the latest run's tasks are available");
6666
osparc.FlashMessenger.logAs(msg, "WARNING");
6767
return;
@@ -72,7 +72,7 @@ qx.Class.define("osparc.jobs.ActivityOverview", {
7272
tasksLayout.remove(this.__subRunsTable);
7373
this.__subRunsTable = null;
7474
}
75-
const subRunsTable = this.__subRunsTable = new osparc.jobs.SubRunsTable(project["projectUuid"]);
75+
const subRunsTable = this.__subRunsTable = new osparc.jobs.SubRunsTable(collectionRunData["collectionRunId"]);
7676
tasksLayout.add(subRunsTable, {
7777
flex: 1
7878
});
@@ -106,12 +106,11 @@ qx.Class.define("osparc.jobs.ActivityOverview", {
106106
runsHistoryLayout.add(introText);
107107

108108
const projectUuid = projectData["uuid"];
109-
const includeChildren = true;
110109
const runningOnly = false;
111-
const runsTable = this.__runsTable = new osparc.jobs.RunsTable(projectUuid, includeChildren, runningOnly);
110+
const runsTable = this.__runsTable = new osparc.jobs.RunsTable(projectUuid, runningOnly);
112111
const columnModel = runsTable.getTableColumnModel();
113112
// Hide project name column
114-
columnModel.setColumnVisible(osparc.jobs.RunsTable.COLS.PROJECT_NAME.column, false);
113+
columnModel.setColumnVisible(osparc.jobs.RunsTable.COLS.NAME.column, false);
115114
// Hide cancel column
116115
columnModel.setColumnVisible(osparc.jobs.RunsTable.COLS.ACTION_CANCEL.column, false);
117116
runsHistoryLayout.add(runsTable, {

services/static-webserver/client/source/class/osparc/jobs/RunsBrowser.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,8 @@ qx.Class.define("osparc.jobs.RunsBrowser", {
8585
break;
8686
case "runs-table": {
8787
const projectUuid = null;
88-
const includeChildren = false;
8988
const runningOnly = true;
90-
control = new osparc.jobs.RunsTable(projectUuid, includeChildren, runningOnly);
89+
control = new osparc.jobs.RunsTable(projectUuid, runningOnly);
9190
control.addListener("runSelected", e => this.fireDataEvent("runSelected", e.getData()));
9291
this._add(control);
9392
break;

0 commit comments

Comments
 (0)