Skip to content

Commit 4c66094

Browse files
fix HttpUrl type
1 parent bb48cd5 commit 4c66094

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

packages/models-library/src/models_library/basic_types.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from typing import Annotated, Final, TypeAlias
55

66
import pydantic
7-
from pydantic import Field, HttpUrl, PositiveInt, StringConstraints
7+
from pydantic import Field, PositiveInt, StringConstraints
88
from pydantic_core import core_schema
99

1010
from .basic_regex import (
@@ -133,6 +133,8 @@ class LongTruncatedStr(ConstrainedStr):
133133

134134
AnyHttpUrl = Annotated[str, pydantic.AnyHttpUrl]
135135

136+
HttpUrl = Annotated[str, pydantic.HttpUrl]
137+
136138
# https e.g. https://techterms.com/definition/https
137139
class HttpSecureUrl(HttpUrl):
138140
allowed_schemes = {"https"}

packages/models-library/src/models_library/services_base.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
from pydantic import BaseModel, ConfigDict, Field, HttpUrl, validator
1+
from pydantic import BaseModel, ConfigDict, Field, field_validator
22

3+
from .basic_types import HttpUrl
34
from .services_types import ServiceKey, ServiceVersion
45
from .utils.common_validators import empty_str_to_none_pre_validator
56

@@ -31,6 +32,7 @@ class ServiceBaseDisplay(BaseModel):
3132
examples=[
3233
"https://user-images.githubusercontent.com/32800795/61083844-ff48fb00-a42c-11e9-8e63-fa2d709c8baf.png"
3334
],
35+
validate_default=True,
3436
)
3537
description: str = Field(
3638
...,
@@ -52,6 +54,6 @@ class ServiceBaseDisplay(BaseModel):
5254
" This name is not used for version comparison but is useful for communication and documentation purposes.",
5355
)
5456

55-
_empty_is_none = validator("thumbnail", allow_reuse=True, pre=True, always=False)(
57+
_empty_is_none = field_validator("thumbnail", mode="before")(
5658
empty_str_to_none_pre_validator
5759
)

0 commit comments

Comments
 (0)