Skip to content

Commit 4cd7bdd

Browse files
fix repo
1 parent 4a554d5 commit 4cd7bdd

File tree

2 files changed

+6
-30
lines changed

2 files changed

+6
-30
lines changed

services/web/server/src/simcore_service_webserver/api_keys/_controller_rpc.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
from datetime import timedelta
2+
13
from aiohttp import web
24
from models_library.api_schemas_webserver import WEBSERVER_RPC_NAMESPACE
3-
from models_library.api_schemas_webserver.auth import ApiKeyCreateRequest
45
from models_library.products import ProductName
56
from models_library.rpc.webserver.auth.api_keys import ApiKeyGet
67
from models_library.users import UserID
@@ -20,14 +21,15 @@ async def create_api_key(
2021
*,
2122
user_id: UserID,
2223
product_name: ProductName,
23-
api_key: ApiKeyCreateRequest,
24+
display_name: str,
25+
expiration: timedelta | None = None,
2426
) -> ApiKeyGet:
2527
created_api_key: ApiKey = await _service.create_api_key(
2628
app,
2729
user_id=user_id,
2830
product_name=product_name,
29-
display_name=api_key.display_name,
30-
expiration=api_key.expiration,
31+
display_name=display_name,
32+
expiration=expiration,
3133
)
3234

3335
return ApiKeyGet.model_validate(created_api_key)

services/web/server/src/simcore_service_webserver/api_keys/_repository.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
import sqlalchemy as sa
55
from aiohttp import web
6-
from asyncpg.exceptions import UniqueViolationError
76
from models_library.products import ProductName
87
from models_library.users import UserID
98
from simcore_postgres_database.models.api_keys import api_keys
@@ -15,7 +14,6 @@
1514
from sqlalchemy.ext.asyncio import AsyncConnection
1615

1716
from ..db.plugin import get_asyncpg_engine
18-
from .errors import ApiKeyDuplicatedDisplayNameError
1917
from .models import ApiKey
2018

2119
_logger = logging.getLogger(__name__)
@@ -36,30 +34,6 @@ async def create_api_key(
3634
api_key: str,
3735
api_secret: str,
3836
) -> ApiKey:
39-
async with transaction_context(get_asyncpg_engine(app), connection) as conn:
40-
stmt = pg_insert(api_keys).values(
41-
display_name=display_name,
42-
user_id=user_id,
43-
product_name=product_name,
44-
api_key=api_key,
45-
api_secret=_hash_secret(api_secret),
46-
expires_at=(sa.func.now() + expiration) if expiration else None,
47-
)
48-
49-
try:
50-
result = await conn.stream(stmt.returning(api_keys))
51-
row = await result.one()
52-
except UniqueViolationError as exc:
53-
raise ApiKeyDuplicatedDisplayNameError(display_name=display_name) from exc
54-
55-
return ApiKey(
56-
id=f"{row.id}", # NOTE See: https://github.com/ITISFoundation/osparc-simcore/issues/6919
57-
display_name=display_name,
58-
expiration=expiration,
59-
api_key=api_key,
60-
api_secret=api_secret,
61-
)
62-
6337
async with transaction_context(get_asyncpg_engine(app), connection) as conn:
6438
stmt = (
6539
pg_insert(api_keys)

0 commit comments

Comments
 (0)