better reading

Author: odeimaiz

services/static-webserver/client/source/class/osparc/dashboard/CardBase.js

@@ -122,36 +122,40 @@ qx.Class.define("osparc.dashboard.CardBase", {
         const groupsStore = osparc.store.Groups.getInstance();
         const myGroupId = groupsStore.getMyGroupId();
 
-        if (sharedWith === "show-all") {
-          // show all
-          return false;
-        } else if (sharedWith === "shared-with-everyone") {
-          const everyoneGroupIds = [
-            groupsStore.getEveryoneProductGroup().getGroupId(),
-            groupsStore.getEveryoneGroup().getGroupId(),
-          ];
-          const found = Object.keys(checks).some(gId => everyoneGroupIds.includes(parseInt(gId)));
-          // show those that are shared with "1" or product everyone's groupId
-          return !found;
-        } else if (sharedWith === "my-resources") {
-          if (myGroupId in checks) {
-            const myAccessRights = checks[myGroupId];
-            const totalAccess = "delete" in myAccessRights ? myAccessRights["delete"] : myAccessRights["write"];
-            // show those that I have ownership of: have explicit delete (study/template) or write (service) access
-            return !totalAccess;
+        switch (sharedWith) {
+          case "show-all":
+            return false;
+          case "shared-with-everyone": {
+            const everyoneGroupIds = [
+              groupsStore.getEveryoneProductGroup().getGroupId(),
+              groupsStore.getEveryoneGroup().getGroupId(),
+            ];
+            const found = Object.keys(checks).some(gId => everyoneGroupIds.includes(parseInt(gId)));
+            // show those that are shared with "1" or product everyone's groupId
+            return !found;
           }
-          return true;
-        } else if (sharedWith === "shared-with-me") {
-          if (myGroupId in checks) {
-            const myAccessRights = checks[myGroupId];
-            const totalAccess = "delete" in myAccessRights ? myAccessRights["delete"] : myAccessRights["write"];
-            // hide those that I'm ownership of: have explicit and delete (study/template) or write (service) access
-            return totalAccess;
+          case "my-resources": {
+            if (myGroupId in checks) {
+              const myAccessRights = checks[myGroupId];
+              const totalAccess = "delete" in myAccessRights ? myAccessRights["delete"] : myAccessRights["write"];
+              // show those that I have ownership of: have explicit delete (study/template) or write (service) access
+              return !totalAccess;
+            }
+            return true;
+          }
+          case "shared-with-me": {
+            if (myGroupId in checks) {
+              const myAccessRights = checks[myGroupId];
+              const totalAccess = "delete" in myAccessRights ? myAccessRights["delete"] : myAccessRights["write"];
+              // hide those that I'm ownership of: have explicit and delete (study/template) or write (service) access
+              return totalAccess;
+            }
+            // if we get here, it means that it was shared-with-me via an organization
+            return false;
           }
-          // if we get here, it means that it was shared-with-me via an organization
-          return false;
+          default:
+            return true;
         }
-        return true;
       }
       return false;
     },