Skip to content

Commit 4f42a25

Browse files
committed
ensure ci workflows are required
1 parent 80ec30b commit 4f42a25

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

.github/workflows/ci-testing-deploy.yml

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2655,6 +2655,8 @@ jobs:
26552655
system-test-environment-setup,
26562656
system-test-public-api,
26572657
system-test-swarm-deploy,
2658+
system-api-specs,
2659+
system-backwards-compatibility
26582660
]
26592661
runs-on: ubuntu-latest
26602662
steps:
@@ -2720,7 +2722,7 @@ jobs:
27202722
TAG_PREFIX: hotfix-staging-github
27212723
run: ./ci/deploy/dockerhub-deploy.bash -n
27222724

2723-
check-api-specs-updated:
2725+
system-api-specs:
27242726
needs: [changes]
27252727
if: ${{ needs.changes.outputs.anything-py == 'true' || github.event_name == 'push' }}
27262728
timeout-minutes: 10
@@ -2746,13 +2748,11 @@ jobs:
27462748
https://raw.githubusercontent.com/${{ github.repository }}/refs/heads/${{ github.ref }} \
27472749
.
27482750
2749-
2750-
api-spec-backwards-compatible:
2751+
system-backwards-compatibility:
27512752
needs: [changes]
27522753
if: ${{ needs.changes.outputs.anything-py == 'true' || github.event_name == 'push' }}
2753-
continue-on-error: true
27542754
timeout-minutes: 10
2755-
name: "api-specs-backwards-compatibility"
2755+
name: "[sys] api-server backwards compatibility"
27562756
runs-on: ubuntu-latest
27572757
steps:
27582758
- name: setup python environment
@@ -2766,17 +2766,18 @@ jobs:
27662766
enable-cache: false
27672767
- name: checkout
27682768
uses: actions/checkout@v4
2769-
- name: Check openapi-specs backwards compatibility
2769+
- name: sheck api-server backwards compatibility
27702770
run: |
2771-
./ci/github/helpers/openapi-specs-backwards-compatibility.bash breaking \
2772-
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }} \
2773-
.
2771+
./scripts/openapi-diff.bash breaking --fail-on ERR\
2772+
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }}/services/api-server/openapi.json \
2773+
/specs/services/api-server/openapi.json
27742774
2775-
api-server-backwards-compatible:
2775+
api-spec-backwards-compatibility:
27762776
needs: [changes]
27772777
if: ${{ needs.changes.outputs.anything-py == 'true' || github.event_name == 'push' }}
2778+
continue-on-error: true
27782779
timeout-minutes: 10
2779-
name: "api-server-backwards-compatibility"
2780+
name: "api-specs-backwards-compatibility"
27802781
runs-on: ubuntu-latest
27812782
steps:
27822783
- name: setup python environment
@@ -2790,8 +2791,8 @@ jobs:
27902791
enable-cache: false
27912792
- name: checkout
27922793
uses: actions/checkout@v4
2793-
- name: Check api-server backwards compatibility
2794+
- name: Check openapi-specs backwards compatibility
27942795
run: |
2795-
./scripts/openapi-diff.bash breaking --fail-on ERR\
2796-
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }}/services/api-server/openapi.json \
2797-
/specs/services/api-server/openapi.json
2796+
./ci/github/helpers/openapi-specs-backwards-compatibility.bash breaking \
2797+
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }} \
2798+
.

0 commit comments

Comments
 (0)