Skip to content

Commit 5030332

Browse files
committed
fix tests
1 parent f346ab2 commit 5030332

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

packages/service-library/src/servicelib/aiohttp/monitoring.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,17 +95,20 @@ async def middleware_handler(request: web.Request, handler: Handler):
9595
except web.HTTPServerError as exc:
9696
resp = exc
9797
log_exception = exc
98+
raise resp
9899
except web.HTTPException as exc:
99100
resp = exc
100101
log_exception = None
102+
raise resp
101103
except asyncio.CancelledError as exc:
102104
resp = web.HTTPInternalServerError(reason=f"{exc}")
103105
log_exception = exc
104-
raise
106+
raise resp
105107
except Exception as exc: # pylint: disable=broad-except
106108
resp = web.HTTPInternalServerError(reason=f"{exc}")
107109
resp.__cause__ = exc
108110
log_exception = exc
111+
raise resp
109112

110113
finally:
111114
resp_time_secs: float = time.time() - start_time

services/web/server/tests/unit/isolated/test_tracing.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,4 @@ def test_middleware_restrictions_opentelemetry_is_second_middleware(
3535

3636
app = create_application()
3737
assert app.middlewares
38-
assert (
39-
app.middlewares[0].__middleware_name__
40-
== "servicelib.aiohttp.monitoring.monitor_simcore_service_webserver"
41-
)
42-
assert app.middlewares[1] is aiohttp_opentelemetry_middleware
38+
assert app.middlewares[0] is aiohttp_opentelemetry_middleware

0 commit comments

Comments
 (0)