Skip to content

Commit 5138e42

Browse files
committed
only get a single page to get latest released service
1 parent 85d61c3 commit 5138e42

File tree

1 file changed

+9
-16
lines changed

1 file changed

+9
-16
lines changed

services/api-server/src/simcore_service_api_server/_service_solvers.py

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
from typing import Annotated
22

3-
from common_library.pagination_tools import iter_pagination_params
43
from fastapi import Depends
54
from models_library.basic_types import VersionStr
65
from models_library.products import ProductName
76
from models_library.rest_pagination import MAXIMUM_NUMBER_OF_ITEMS_PER_PAGE
87
from models_library.services_enums import ServiceType
9-
from models_library.services_history import ServiceRelease
108
from models_library.users import UserID
11-
from packaging.version import Version
129

1310
from .models.schemas.solvers import Solver, SolverKeyId
1411
from .services_rpc.catalog import CatalogService
@@ -49,23 +46,19 @@ async def get_latest_release(
4946
solver_key: SolverKeyId,
5047
product_name: str,
5148
) -> Solver:
52-
service_releases: list[ServiceRelease] = []
53-
for page_params in iter_pagination_params(limit=DEFAULT_PAGINATION_LIMIT):
54-
releases, page_meta = await self._catalog_service.list_release_history(
55-
user_id=user_id,
56-
service_key=solver_key,
57-
product_name=product_name,
58-
offset=page_params.offset,
59-
limit=page_params.limit,
60-
)
61-
page_params.total_number_of_items = page_meta.total
62-
service_releases.extend(releases)
49+
releases, _ = await self._catalog_service.list_release_history(
50+
user_id=user_id,
51+
service_key=solver_key,
52+
product_name=product_name,
53+
offset=0,
54+
limit=1,
55+
)
6356

64-
release = sorted(service_releases, key=lambda s: Version(s.version))[-1]
57+
assert len(releases) == 1 # nosec
6558
service = await self._catalog_service.get(
6659
user_id=user_id,
6760
name=solver_key,
68-
version=release.version,
61+
version=releases[0].version,
6962
product_name=product_name,
7063
)
7164

0 commit comments

Comments
 (0)