ensure aiothtp_server gets the right loop + hack for pytest-asyncio

Author: sanderegg

services/web/server/tests/unit/with_dbs/01/storage/test_storage.py

@@ -79,6 +79,18 @@
 ]
 
 
+@pytest.mark.xfail(
+    reason="This is really weird: A first test that fails is necessary to make this test module work with pytest-asyncio>=0.24.0. "
+    "Maybe because of module/session event loops?"
+)
+async def test_pytest_asyncio_failure(
+    client: TestClient,
+):
+    url = "/v0/storage/locations"
+    assert url.startswith(PREFIX)
+    await client.get(url)
+
+
 @pytest.mark.parametrize(
     "user_role,expected",
     [
@@ -95,7 +107,6 @@ async def test_list_storage_locations(
 ):
     url = "/v0/storage/locations"
     assert url.startswith(PREFIX)
-
     resp = await client.get(url)
     data, error = await assert_status(resp, expected)
 

services/web/server/tests/unit/with_dbs/01/storage/test_storage_handlers.py

@@ -89,6 +89,20 @@ def _resolve(*args, **kwargs) -> AnyUrl:
 DOUBLE_ENCODE_SLASH_IN_FILE_ID = "ef944bbe-14c7-11ee-a195-02420a0f07ab%252F46ac4913-92dc-432c-98e3-2dea21d3f0ed%252Fa_text_file.txt"
 SINGLE_ENCODE_SLASH_IN_FILE_ID = "ef944bbe-14c7-11ee-a195-02420a0f07ab%2F46ac4913-92dc-432c-98e3-2dea21d3f0ed%2Fa_text_file.txt"
 
+PREFIX = "/" + "v0" + "/storage"
+
+
+@pytest.mark.xfail(
+    reason="This is really weird: A first test that fails is necessary to make this test module work with pytest-asyncio>=0.24.0. "
+    "Maybe because of module/session event loops?"
+)
+async def test_pytest_asyncio_failure(
+    client: TestClient,
+):
+    url = "/v0/storage/locations"
+    assert url.startswith(PREFIX)
+    await client.get(url)
+
 
 @pytest.mark.parametrize("user_role", [UserRole.USER])
 @pytest.mark.parametrize(

services/web/server/tests/unit/with_dbs/conftest.py

@@ -3,6 +3,7 @@
 # pylint: disable=unused-variable
 # pylint: disable=too-many-arguments
 
+import asyncio
 import random
 import sys
 import textwrap
@@ -24,6 +25,7 @@
 
 import aiopg.sa
 import pytest
+import pytest_asyncio
 import redis
 import redis.asyncio as aioredis
 import simcore_postgres_database.cli as pg_cli
@@ -204,7 +206,13 @@ async def _print_mail_to_stdout(
     )
 
 
-@pytest.fixture
+@pytest_asyncio.fixture(loop_scope="function")
+async def loop() -> asyncio.AbstractEventLoop:
+    # NOTE: This is a hack to ensure the loop is set in the aiohttp_server
+    return asyncio.get_running_loop()
+
+
+@pytest_asyncio.fixture(loop_scope="function")
 async def web_server(
     app_environment: EnvVarsDict,
     postgres_db: sa.engine.Engine,