ensure mock does the right thing

Author: sanderegg

packages/aws-library/src/aws_library/ec2/_client.py

@@ -248,7 +248,9 @@ async def launch_instances(
                     break
                 except botocore.exceptions.ClientError as exc:
                     error_code = exc.response.get("Error", {}).get("Code")
-                    if error_code == "InsufficientInstanceCapacity":
+                    if error_code == "500" and (
+                        "InsufficientInstanceCapacity" in f"{exc}"
+                    ):
                         _logger.warning(
                             "Insufficient capacity in subnet %s for instance type %s, trying next subnet",
                             subnet_id,

packages/aws-library/tests/test_ec2_client.py

@@ -623,7 +623,7 @@ async def mock_run_instances(*args, **kwargs) -> Any:
             # First call (first subnet) - simulate insufficient capacity
             error_response: dict[str, Any] = {
                 "Error": {
-                    "Code": "InsufficientInstanceCapacity",
+                    "Code": "500",
                     "Message": "Insufficient capacity.",
                 },
             }
@@ -707,7 +707,7 @@ async def mock_run_instances(*args, **kwargs) -> Any:
         # Always simulate insufficient capacity
         error_response = {
             "Error": {
-                "Code": "InsufficientInstanceCapacity",
+                "Code": "500",
                 "Message": "Insufficient capacity.",
             },
         }
@@ -784,7 +784,7 @@ async def mock_run_instances(*args, **kwargs):
         # Second call: simulate insufficient capacity (subnet is full)
         error_response = {
             "Error": {
-                "Code": "InsufficientInstanceCapacity",
+                "Code": "500",
                 "Message": "Insufficient capacity.",
             },
         }