Skip to content

Commit 52b2604

Browse files
committed
fixing tests
1 parent 3dcfbc4 commit 52b2604

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

services/api-server/tests/unit/api_solvers/test_api_routers_solvers_jobs.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def presigned_download_link(
8282

8383

8484
@pytest.fixture
85-
def mocked_directorv2_service_api(
85+
def mocked_directorv2_rest_api(
8686
app: FastAPI,
8787
presigned_download_link: AnyUrl,
8888
mocked_directorv2_rest_api_base: MockRouter,
@@ -166,7 +166,7 @@ def test_download_presigned_link(
166166

167167
async def test_solver_logs(
168168
client: httpx.AsyncClient,
169-
mocked_directorv2_service_api: MockRouter,
169+
mocked_directorv2_rest_api: MockRouter,
170170
auth: httpx.BasicAuth,
171171
project_id: str,
172172
presigned_download_link: AnyUrl,
@@ -185,7 +185,7 @@ async def test_solver_logs(
185185
)
186186

187187
# calls to directorv2 service
188-
assert mocked_directorv2_service_api["get_computation_logs"].called
188+
assert mocked_directorv2_rest_api["get_computation_logs"].called
189189

190190
# was a re-direction
191191
resp0 = resp.history[0]
@@ -204,7 +204,7 @@ async def test_run_solver_job(
204204
directorv2_service_openapi_specs: dict[str, Any],
205205
catalog_service_openapi_specs: dict[str, Any],
206206
mocked_catalog_rpc_api: dict[str, MockType],
207-
mocked_directorv2_service_api: MockRouter,
207+
mocked_directorv2_rest_api: MockRouter,
208208
mocked_webserver_rest_api: MockRouter,
209209
mocked_webserver_rpc_api: dict[str, MockType],
210210
auth: httpx.BasicAuth,
@@ -239,7 +239,7 @@ async def test_run_solver_job(
239239
} == set(oas["components"]["schemas"]["ComputationGet"]["properties"].keys())
240240

241241
# CREATE and optionally start
242-
mocked_directorv2_service_api.get(
242+
mocked_directorv2_rest_api.get(
243243
path__regex=r"^/v2/computations/[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-(3|4|5)[0-9a-fA-F]{3}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$",
244244
name="inspect_computation",
245245
).respond(
@@ -349,7 +349,7 @@ async def test_run_solver_job(
349349
auth=auth,
350350
)
351351
assert resp.status_code == status.HTTP_202_ACCEPTED
352-
assert mocked_directorv2_service_api["inspect_computation"].called
352+
assert mocked_directorv2_rest_api["inspect_computation"].called
353353

354354
job_status = JobStatus.model_validate(resp.json())
355355
assert job_status.progress == 0.0

services/api-server/tests/unit/conftest.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,10 @@ def _get_rabbitmq_rpc_client_override():
326326
async def _get_wb_api_rpc_client_override():
327327
from simcore_service_api_server.services_rpc import wb_api_server
328328

329-
wb_api_server.setup(app, rabbitmq_rpc_client=mocked_rabbit_rpc_client)
329+
try:
330+
return WbApiRpcClient.get_from_app_state(app)
331+
except AttributeError:
332+
wb_api_server.setup(app, rabbitmq_rpc_client=mocked_rabbit_rpc_client)
330333
return WbApiRpcClient.get_from_app_state(app)
331334

332335
app.dependency_overrides[get_wb_api_rpc_client] = _get_wb_api_rpc_client_override

0 commit comments

Comments
 (0)