refactor: update method names from_service_io to from_domain_model for clarity

Author: pcrespov

packages/models-library/src/models_library/api_schemas_catalog/services_ports.py

@@ -16,7 +16,7 @@
 class ServicePortGet(BaseModel):
     key: str = Field(
         ...,
-        description="port identifier name",
+        description="Port identifier name",
         pattern=PUBLIC_VARIABLE_NAME_RE,
         title="Key name",
     )
@@ -26,6 +26,7 @@ class ServicePortGet(BaseModel):
         None,
         description="jsonschema for the port's value. SEE https://json-schema.org/understanding-json-schema/",
     )
+
     model_config = ConfigDict(
         json_schema_extra={
             "example": {
@@ -43,7 +44,7 @@ class ServicePortGet(BaseModel):
     )
 
     @classmethod
-    def from_service_io(
+    def from_domain_model(
         cls,
         kind: PortKindStr,
         key: str,

packages/models-library/tests/test_api_schemas_catalog.py

@@ -21,7 +21,7 @@ def test_service_port_with_file():
         }
     )
 
-    port = ServicePortGet.from_service_io("input", "input_1", io).model_dump(
+    port = ServicePortGet.from_domain_model("input", "input_1", io).model_dump(
         exclude_unset=True
     )
 
@@ -49,7 +49,7 @@ def test_service_port_with_boolean():
         }
     )
 
-    port = ServicePortGet.from_service_io("input", "input_1", io).model_dump(
+    port = ServicePortGet.from_domain_model("input", "input_1", io).model_dump(
         exclude_unset=True
     )
 

services/catalog/src/simcore_service_catalog/api/rest/_services_ports.py

@@ -31,10 +31,18 @@ async def list_service_ports(
 
     if service.inputs:
         for name, input_port in service.inputs.items():
-            ports.append(ServicePortGet.from_service_io("input", name, input_port))
+            ports.append(
+                ServicePortGet.from_domain_model(
+                    kind="input", key=name, port=input_port
+                )
+            )
 
     if service.outputs:
         for name, output_port in service.outputs.items():
-            ports.append(ServicePortGet.from_service_io("output", name, output_port))
+            ports.append(
+                ServicePortGet.from_domain_model(
+                    kind="output", key=name, port=output_port
+                )
+            )
 
     return ports