Skip to content

Commit 55250fa

Browse files
Merge branch 'master' into add-some-logs-to-project-creation
2 parents 522dab3 + 4777c9e commit 55250fa

File tree

45 files changed

+136
-198
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+136
-198
lines changed

api/specs/web-server/_long_running_tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from models_library.generics import Envelope
1111
from models_library.rest_error import EnvelopedError
1212
from servicelib.aiohttp.long_running_tasks._routes import _PathParam
13-
from servicelib.long_running_tasks._models import TaskGet, TaskStatus
13+
from servicelib.long_running_tasks.models import TaskGet, TaskStatus
1414
from simcore_service_webserver._meta import API_VTAG
1515
from simcore_service_webserver.tasks._exception_handlers import (
1616
_TO_HTTP_ERROR_MAP as export_data_http_error_map,

api/specs/web-server/_long_running_tasks_legacy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from fastapi import APIRouter, Depends, status
1010
from models_library.generics import Envelope
1111
from servicelib.aiohttp.long_running_tasks._routes import _PathParam
12-
from servicelib.long_running_tasks._models import TaskGet, TaskStatus
12+
from servicelib.long_running_tasks.models import TaskGet, TaskStatus
1313
from simcore_service_webserver._meta import API_VTAG
1414

1515
router = APIRouter(

packages/service-library/src/servicelib/aiohttp/long_running_tasks/_dependencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from aiohttp import web
44

5-
from ...long_running_tasks._task import TasksManager
5+
from ...long_running_tasks.task import TasksManager
66
from ._constants import (
77
APP_LONG_RUNNING_TASKS_MANAGER_KEY,
88
RQT_LONG_RUNNING_TASKS_CONTEXT_KEY,

packages/service-library/src/servicelib/aiohttp/long_running_tasks/_error_handlers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from aiohttp import web
44
from common_library.json_serialization import json_dumps
55

6-
from ...long_running_tasks._errors import (
6+
from ...long_running_tasks.errors import (
77
TaskCancelledError,
88
TaskNotCompletedError,
99
TaskNotFoundError,

packages/service-library/src/servicelib/aiohttp/long_running_tasks/_routes.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
from pydantic import BaseModel
77
from servicelib.aiohttp import status
88

9-
from ...long_running_tasks._errors import TaskNotCompletedError, TaskNotFoundError
10-
from ...long_running_tasks._models import TaskGet, TaskId, TaskStatus
11-
from ...long_running_tasks._task import TrackedTask
9+
from ...long_running_tasks.errors import TaskNotCompletedError, TaskNotFoundError
10+
from ...long_running_tasks.models import TaskGet, TaskId, TaskStatus
11+
from ...long_running_tasks.task import TrackedTask
1212
from ..requests_validation import parse_request_path_parameters_as
1313
from ._dependencies import get_task_context, get_tasks_manager
1414

packages/service-library/src/servicelib/aiohttp/long_running_tasks/_server.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
from pydantic import AnyHttpUrl, PositiveFloat, TypeAdapter
1010

1111
from ...aiohttp import status
12-
from ...long_running_tasks._models import TaskGet
13-
from ...long_running_tasks._task import (
12+
from ...long_running_tasks.models import TaskGet
13+
from ...long_running_tasks.task import (
1414
TaskContext,
1515
TaskProtocol,
1616
TasksManager,
@@ -136,11 +136,11 @@ def setup(
136136

137137
async def on_cleanup_ctx(app: web.Application) -> AsyncGenerator[None, None]:
138138
# add components to state
139-
app[
140-
APP_LONG_RUNNING_TASKS_MANAGER_KEY
141-
] = long_running_task_manager = TasksManager(
142-
stale_task_check_interval_s=stale_task_check_interval_s,
143-
stale_task_detect_timeout_s=stale_task_detect_timeout_s,
139+
app[APP_LONG_RUNNING_TASKS_MANAGER_KEY] = long_running_task_manager = (
140+
TasksManager(
141+
stale_task_check_interval_s=stale_task_check_interval_s,
142+
stale_task_detect_timeout_s=stale_task_detect_timeout_s,
143+
)
144144
)
145145

146146
# add error handlers

packages/service-library/src/servicelib/aiohttp/long_running_tasks/client.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,16 @@
1313
from yarl import URL
1414

1515
from ...long_running_tasks._constants import DEFAULT_POLL_INTERVAL_S, HOUR
16-
from ...long_running_tasks._models import LRTask, RequestBody
16+
from ...long_running_tasks.models import (
17+
LRTask,
18+
RequestBody,
19+
TaskGet,
20+
TaskId,
21+
TaskProgress,
22+
TaskStatus,
23+
)
1724
from ...rest_responses import unwrap_envelope_if_required
1825
from .. import status
19-
from .server import TaskGet, TaskId, TaskProgress, TaskStatus
2026

2127
_logger = logging.getLogger(__name__)
2228

@@ -123,6 +129,3 @@ async def long_running_task_request(
123129
if task:
124130
await _abort_task(session, URL(task.abort_href))
125131
raise
126-
127-
128-
__all__: tuple[str, ...] = ("LRTask",)

packages/service-library/src/servicelib/aiohttp/long_running_tasks/server.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,39 +6,19 @@
66
running task.
77
"""
88

9-
from ...long_running_tasks._errors import TaskAlreadyRunningError, TaskCancelledError
10-
from ...long_running_tasks._models import ProgressMessage, ProgressPercent
11-
from ...long_running_tasks._task import (
12-
TaskId,
13-
TaskProgress,
14-
TaskProtocol,
15-
TasksManager,
16-
TaskStatus,
17-
)
189
from ._dependencies import (
1910
create_task_name_from_request,
2011
get_task_context,
2112
get_tasks_manager,
2213
)
23-
from ._routes import TaskGet
2414
from ._server import setup, start_long_running_task
2515

2616
__all__: tuple[str, ...] = (
2717
"create_task_name_from_request",
2818
"get_task_context",
2919
"get_tasks_manager",
30-
"ProgressMessage",
31-
"ProgressPercent",
3220
"setup",
3321
"start_long_running_task",
34-
"TaskAlreadyRunningError",
35-
"TaskCancelledError",
36-
"TaskId",
37-
"TaskGet",
38-
"TasksManager",
39-
"TaskProgress",
40-
"TaskProtocol",
41-
"TaskStatus",
4222
)
4323

4424
# nopycln: file

packages/service-library/src/servicelib/fastapi/long_running_tasks/_client.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
from tenacity.stop import stop_after_attempt
1515
from tenacity.wait import wait_exponential
1616

17-
from ...long_running_tasks._errors import GenericClientError
18-
from ...long_running_tasks._models import ClientConfiguration, TaskId, TaskStatus
17+
from ...long_running_tasks.errors import GenericClientError
18+
from ...long_running_tasks.models import ClientConfiguration, TaskId, TaskStatus
1919

20-
DEFAULT_HTTP_REQUESTS_TIMEOUT: Final[PositiveFloat] = 15
20+
_DEFAULT_HTTP_REQUESTS_TIMEOUT: Final[PositiveFloat] = 15
2121

2222

2323
logger = logging.getLogger(__name__)
@@ -207,7 +207,7 @@ def setup(
207207
app: FastAPI,
208208
*,
209209
router_prefix: str = "",
210-
http_requests_timeout: PositiveFloat = DEFAULT_HTTP_REQUESTS_TIMEOUT,
210+
http_requests_timeout: PositiveFloat = _DEFAULT_HTTP_REQUESTS_TIMEOUT,
211211
):
212212
"""
213213
- `router_prefix` by default it is assumed the server mounts the APIs on

packages/service-library/src/servicelib/fastapi/long_running_tasks/_context_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66

77
from pydantic import PositiveFloat
88

9-
from ...long_running_tasks._errors import TaskClientTimeoutError
10-
from ...long_running_tasks._models import (
9+
from ...long_running_tasks.errors import TaskClientTimeoutError
10+
from ...long_running_tasks.models import (
1111
ProgressCallback,
1212
ProgressMessage,
1313
ProgressPercent,

0 commit comments

Comments
 (0)