added test to ensure it never changes

Author: Andrei Neagu

packages/service-library/src/servicelib/long_running_tasks/_redis_store.py

@@ -12,6 +12,7 @@
 
 _STORE_TYPE_TASK_DATA: Final[str] = "TD"
 _LIST_CONCURRENCY: Final[int] = 3
+_MARKED_FOR_REMOVAL_FIELD: Final[str] = "marked_for_removal"
 
 
 def _to_redis_hash_mapping(data: dict[str, Any]) -> dict[str, str]:
@@ -115,14 +116,14 @@ async def mark_task_for_removal(self, task_id: TaskId) -> None:
         await handle_redis_returns_union_types(
             self._redis.hset(
                 self._get_redis_task_data_key(task_id),
-                mapping=_to_redis_hash_mapping({"marked_for_removal": True}),
+                mapping=_to_redis_hash_mapping({_MARKED_FOR_REMOVAL_FIELD: True}),
             )
         )
 
     async def is_marked_for_removal(self, task_id: TaskId) -> bool:
         result = await handle_redis_returns_union_types(
             self._redis.hget(
-                self._get_redis_task_data_key(task_id), "marked_for_removal"
+                self._get_redis_task_data_key(task_id), _MARKED_FOR_REMOVAL_FIELD
             )
         )
         return False if result is None else json_loads(result)

packages/service-library/tests/long_running_tasks/test_long_running_tasks__store.py renamed to packages/service-library/tests/long_running_tasks/test_long_running_tasks__redis_store.py

@@ -6,12 +6,21 @@
 
 import pytest
 from pydantic import TypeAdapter
-from servicelib.long_running_tasks._redis_store import RedisStore
+from servicelib.long_running_tasks._redis_store import (
+    _MARKED_FOR_REMOVAL_FIELD,
+    RedisStore,
+)
 from servicelib.long_running_tasks.models import TaskData
 from servicelib.redis._client import RedisClientSDK
 from settings_library.redis import RedisDatabase, RedisSettings
 
 
+def test_ensure_task_data_field_name_and_type():
+    # ensure this does not change since it's queied for the remal as a single entity
+    field = TaskData.model_fields[_MARKED_FOR_REMOVAL_FIELD]
+    assert field.annotation is bool
+
+
 @pytest.fixture
 def task_data() -> TaskData:
     return TypeAdapter(TaskData).validate_python(