fixes payments

Author: pcrespov

services/payments/src/simcore_service_payments/api/rest/_acknowledgements.py

@@ -77,18 +77,23 @@ async def acknowledge_payment(
     )
 
     if ack.saved:
-        inserted = await payments_methods.insert_payment_method(
-            repo=repo_methods,
-            payment_method_id=ack.saved.payment_method_id,
-            user_id=transaction.user_id,
-            wallet_id=transaction.wallet_id,
-            ack=ack.saved,
-        )
-        background_tasks.add_task(
-            payments_methods.on_payment_method_completed,
-            payment_method=inserted,
-            notifier=notifier,
-        )
+        if ack.saved.payment_method_id is None:
+            _logger.error("Failed to ")  # failed to save create-card
+            # TODO: notify failure to save !
+        else:
+            inserted = await payments_methods.insert_payment_method(
+                repo=repo_methods,
+                payment_method_id=ack.saved.payment_method_id,
+                user_id=transaction.user_id,
+                wallet_id=transaction.wallet_id,
+                ack=ack.saved,
+            )
+
+            background_tasks.add_task(
+                payments_methods.on_payment_method_completed,
+                payment_method=inserted,
+                notifier=notifier,
+            )
 
 
 @router.post("/payments-methods/{payment_method_id}:ack")

services/payments/src/simcore_service_payments/models/schemas/acknowledgements.py

@@ -42,7 +42,7 @@ class AckPaymentMethod(_BaseAck):
 
 
 class SavedPaymentMethod(AckPaymentMethod):
-    payment_method_id: PaymentMethodID
+    payment_method_id: PaymentMethodID | None = None
 
 
 #
@@ -83,11 +83,14 @@ class SavedPaymentMethod(AckPaymentMethod):
 
 class AckPayment(_BaseAckPayment):
 
-    saved: SavedPaymentMethod | None = Field(
-        default=None,
-        description="Gets the payment-method if user opted to save it during payment."
-        "If used did not opt to save of payment-method was already saved, then it defaults to None",
-    )
+    saved: Annotated[
+        SavedPaymentMethod | None,
+        Field(
+            description="Gets the payment-method if user opted to save it during payment."
+            "If used did not opt to save of payment-method was already saved, then it defaults to None",
+        ),
+    ] = None
+
     model_config = ConfigDict(
         json_schema_extra={
             "example": _EXAMPLES[1].copy(),  # shown in openapi.json